Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add small tweak to install #1041

Merged
merged 1 commit into from
Nov 21, 2024
Merged

add small tweak to install #1041

merged 1 commit into from
Nov 21, 2024

Conversation

maleck13
Copy link
Collaborator

Signed-off-by: craig [email protected]

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.89%. Comparing base (cc1b41f) to head (a417a3e).
Report is 48 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1041      +/-   ##
==========================================
+ Coverage   76.15%   83.89%   +7.74%     
==========================================
  Files         111       81      -30     
  Lines        8986     6694    -2292     
==========================================
- Hits         6843     5616    -1227     
+ Misses       1852      863     -989     
+ Partials      291      215      -76     
Flag Coverage Δ
bare-k8s-integration 15.70% <ø> (+4.82%) ⬆️
controllers-integration 76.46% <ø> (+17.60%) ⬆️
envoygateway-integration 40.46% <ø> (+7.95%) ⬆️
gatewayapi-integration 16.05% <ø> (+2.61%) ⬆️
istio-integration 43.68% <ø> (+9.35%) ⬆️
unit 18.12% <ø> (-7.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 90.00% <100.00%> (-2.19%) ⬇️
api/v1beta2 (u) ∅ <ø> (∅)
pkg/common (u) ∅ <ø> (∅)
pkg/istio (u) 62.06% <ø> (+15.03%) ⬆️
pkg/log (u) 93.18% <ø> (ø)
pkg/reconcilers (u) 24.67% <ø> (∅)
pkg/rlptools (u) ∅ <ø> (∅)
controllers (i) 86.75% <89.98%> (+2.32%) ⬆️

see 36 files with indirect coverage changes

---- 🚨 Try these New Features:

Signed-off-by: craig <[email protected]>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED

create openshift overlay

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
Copy link
Contributor

@eguzki eguzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

That being said, I think we should promote helm charts as the preferred (and recommended) way to install upstream version of kuadrant, either in bare k8s or Openshift.

@maleck13 maleck13 merged commit be39a2b into main Nov 21, 2024
34 checks passed
@maleck13
Copy link
Collaborator Author

@eguzki sure but this is a nice option also as you can just use kubectl -k

@eguzki eguzki deleted the tweak-install branch November 21, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants