Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have only auth accessing actions happen after auth #1020

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

alexsnaps
Copy link
Member

fixes #375

@alexsnaps
Copy link
Member Author

This should break all integration tests that assert on that order... Waiting for that to happen and then fix

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 91.42857% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.72%. Comparing base (cc1b41f) to head (9c98545).
Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
controllers/envoy_gateway_extension_reconciler.go 57.14% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1020      +/-   ##
==========================================
+ Coverage   76.15%   83.72%   +7.57%     
==========================================
  Files         111       81      -30     
  Lines        8986     6661    -2325     
==========================================
- Hits         6843     5577    -1266     
+ Misses       1852      867     -985     
+ Partials      291      217      -74     
Flag Coverage Δ
bare-k8s-integration 15.87% <0.00%> (+4.99%) ⬆️
controllers-integration 75.97% <45.71%> (+17.11%) ⬆️
envoygateway-integration 40.60% <34.28%> (+8.10%) ⬆️
gatewayapi-integration 16.17% <0.00%> (+2.73%) ⬆️
istio-integration 43.64% <62.85%> (+9.31%) ⬆️
unit 17.21% <42.85%> (-8.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 90.00% <100.00%> (-2.19%) ⬇️
api/v1beta2 (u) ∅ <ø> (∅)
pkg/common (u) ∅ <ø> (∅)
pkg/istio (u) 62.06% <ø> (+15.03%) ⬆️
pkg/log (u) 93.18% <ø> (ø)
pkg/reconcilers (u) 24.67% <ø> (∅)
pkg/rlptools (u) ∅ <ø> (∅)
controllers (i) 86.43% <89.81%> (+2.00%) ⬆️
Files with missing lines Coverage Δ
controllers/istio_extension_reconciler.go 84.33% <100.00%> (+0.83%) ⬆️
pkg/wasm/types.go 72.88% <100.00%> (+3.65%) ⬆️
controllers/envoy_gateway_extension_reconciler.go 83.55% <57.14%> (-0.99%) ⬇️

... and 21 files with indirect coverage changes

@alexsnaps alexsnaps merged commit e6ef741 into main Nov 14, 2024
35 checks passed
@alexsnaps alexsnaps deleted the pre_auth_RL branch November 14, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Pre-auth rate limit
2 participants