Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup obs for v1 #1016

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Fixup obs for v1 #1016

merged 2 commits into from
Nov 13, 2024

Conversation

david-martin
Copy link
Member

  • use latest 0.6.0 release of gateway-api-state-metrics with v1 kuadrant crd versions
  • fixup escaping of $ in podmonitor bash cmd

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.16%. Comparing base (cc1b41f) to head (db28b86).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1016      +/-   ##
==========================================
+ Coverage   76.15%   82.16%   +6.01%     
==========================================
  Files         111       81      -30     
  Lines        8986     6628    -2358     
==========================================
- Hits         6843     5446    -1397     
+ Misses       1852      964     -888     
+ Partials      291      218      -73     
Flag Coverage Δ
bare-k8s-integration 15.64% <ø> (+4.77%) ⬆️
controllers-integration 67.36% <ø> (+8.50%) ⬆️
envoygateway-integration 40.73% <ø> (+8.22%) ⬆️
gatewayapi-integration 16.28% <ø> (+2.85%) ⬆️
istio-integration 43.64% <ø> (+9.31%) ⬆️
unit 17.04% <ø> (-8.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 90.00% <100.00%> (-2.19%) ⬇️
api/v1beta2 (u) ∅ <ø> (∅)
pkg/common (u) ∅ <ø> (∅)
pkg/istio (u) 62.06% <ø> (+15.03%) ⬆️
pkg/log (u) 93.18% <ø> (ø)
pkg/reconcilers (u) 24.67% <ø> (∅)
pkg/rlptools (u) ∅ <ø> (∅)
controllers (i) 84.18% <90.58%> (-0.25%) ⬇️

see 26 files with indirect coverage changes

@maleck13
Copy link
Collaborator

envoy integration tests are failing but I am happy for this to merge as is as it isn't changing anything in that area

@david-martin david-martin merged commit da2d8ce into main Nov 13, 2024
34 of 35 checks passed
@david-martin david-martin deleted the fixup-obs-for-v1 branch November 13, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants