Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add observability steps and configuration #1006

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

david-martin
Copy link
Member

  • cmds added to end of install doc for observability setup
  • Grafana installed via olm
  • dashboards referenced in GrafanaDashboard CRs via existing example dashboard configmaps
  • thanos datasource setup via GrafanaDatasource CR
  • existing servicemonitors applied via kustomize

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.38%. Comparing base (d81be51) to head (7ea3b59).
Report is 1 commits behind head on updated-install-doc.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           updated-install-doc    #1006      +/-   ##
=======================================================
- Coverage                84.01%   79.38%   -4.64%     
=======================================================
  Files                       81      115      +34     
  Lines                     6632     9605    +2973     
=======================================================
+ Hits                      5572     7625    +2053     
- Misses                     851     1573     +722     
- Partials                   209      407     +198     
Flag Coverage Δ
bare-k8s-integration 9.42% <ø> (-5.23%) ⬇️
controllers-integration 68.17% <ø> (-8.29%) ⬇️
envoygateway-integration 47.66% <ø> (+6.75%) ⬆️
gatewayapi-integration 13.10% <ø> (-3.19%) ⬇️
istio-integration 48.68% <ø> (+5.04%) ⬆️
unit 27.54% <ø> (+10.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 90.00% <ø> (ø)
api/v1beta2 (u) ∅ <ø> (∅)
pkg/common (u) 87.67% <ø> (∅)
pkg/istio (u) 58.57% <ø> (-3.50%) ⬇️
pkg/log (u) 93.18% <ø> (ø)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) ∅ <ø> (∅)
controllers (i) 82.68% <ø> (-4.26%) ⬇️

see 131 files with indirect coverage changes

@maleck13 maleck13 merged commit b084d80 into updated-install-doc Nov 12, 2024
24 of 25 checks passed
maleck13 pushed a commit that referenced this pull request Nov 13, 2024
maleck13 added a commit that referenced this pull request Nov 14, 2024
* add a basic kustomize install

Signed-off-by: craig <[email protected]>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED

* Update config/install/README.md

Co-authored-by: Rachel Lawton <[email protected]>

* Add observability steps and configuration (#1006)

Signed-off-by: David Martin <[email protected]>

* updates for install doc

Signed-off-by: craig <[email protected]>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED

Update observability resources to use gateway-system namespace (#969)

Signed-off-by: David Martin <[email protected]>

add example for external api usage

* remove links

Signed-off-by: craig <[email protected]>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED

* Update config/install/README.md

Co-authored-by: Rachel Lawton <[email protected]>

* Update config/install/README.md

Co-authored-by: Rachel Lawton <[email protected]>

* Update config/install/README.md

Co-authored-by: Rachel Lawton <[email protected]>

* Update config/install/README.md

Co-authored-by: Rachel Lawton <[email protected]>

* Apply suggestions from code review

Co-authored-by: Rachel Lawton <[email protected]>

* Update config/install/README.md

Co-authored-by: Rachel Lawton <[email protected]>

* remove links
update multi cluster options

Signed-off-by: craig <[email protected]>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED

* fix indent

Signed-off-by: craig <[email protected]>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED

* re-add changes

Signed-off-by: craig <[email protected]>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED

* re-add changes

Signed-off-by: craig <[email protected]>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED

* Update config/install/README.md

Co-authored-by: Rachel Lawton <[email protected]>

---------

Signed-off-by: David Martin <[email protected]>
Co-authored-by: Rachel Lawton <[email protected]>
Co-authored-by: David Martin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants