unit tests

Makefile

@@ -219,8 +219,11 @@ test: test-unit test-integration ## Run all tests
 test-integration: clean-cov generate fmt vet envtest ## Run Integration tests.
 	KUBEBUILDER_ASSETS="$(shell $(ENVTEST) $(ARCH_PARAM) use $(ENVTEST_K8S_VERSION) -p path)" USE_EXISTING_CLUSTER=true go test ./... -coverprofile $(PROJECT_PATH)/cover.out -tags integration -ginkgo.v -ginkgo.progress -v -timeout 0
 
+ifdef TEST_NAME
+test-unit: TEST_PATTERN := --run $(TEST_NAME)
+endif
 test-unit: clean-cov generate fmt vet ## Run Unit tests.
-	go test ./... -coverprofile $(PROJECT_PATH)/cover.out -tags unit -v -timeout 0
+	go test ./... -coverprofile $(PROJECT_PATH)/cover.out -tags unit -v -timeout 0 $(TEST_PATTERN)
 
 .PHONY: namespace
 namespace: ## Creates a namespace where to deploy Kuadrant Operator

doc/development.md

@@ -218,6 +218,18 @@ make local-cleanup
 make test-unit
 ```
 
+Optionally, add `TEST_NAME` makefile variable to run specific test
+
+```sh
+make test-unit TEST_NAME=TestLimitIndexEquals
+```
+
+or even subtest
+
+```sh
+make test-unit TEST_NAME=TestLimitIndexEquals/limit_conditions_order_does_not_matter
+```
+
 ### Integration tests
 
 You need an active session open to a kubernetes cluster.

pkg/common/common.go

@@ -105,6 +105,19 @@ func SliceCopy[T any](s1 []T) []T {
 	return s2
 }
 
+func ReverseSlice[T any](input []T) []T {
+	inputLen := len(input)
+	output := make([]T, inputLen)
+
+	for i, n := range input {
+		j := inputLen - i - 1
+
+		output[j] = n
+	}
+
+	return output
+}
+
 // MergeMapStringString Merge desired into existing.
 // Not Thread-Safe. Does it matter?
 func MergeMapStringString(existing *map[string]string, desired map[string]string) bool {

pkg/rlptools/limit_index.go

@@ -87,6 +87,17 @@ func SameLimitList(a, b []kuadrantv1beta1.Limit) bool {
 	copy(aCopy, a)
 	copy(bCopy, b)
 
+	// two limits with reordered conditions/variables are effectively the same
+	for idx := range aCopy {
+		sort.Strings(aCopy[idx].Conditions)
+		sort.Strings(aCopy[idx].Variables)
+	}
+
+	for idx := range bCopy {
+		sort.Strings(bCopy[idx].Conditions)
+		sort.Strings(bCopy[idx].Variables)
+	}
+
 	sort.Sort(LimitList(aCopy))
 	sort.Sort(LimitList(bCopy))