Skip to content

Commit

Permalink
GATEWAYAPI_PROVIDER=istio in lowercase
Browse files Browse the repository at this point in the history
  • Loading branch information
eguzki committed May 30, 2024
1 parent c82bcc6 commit 5812c99
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
8 changes: 4 additions & 4 deletions doc/development.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ The `make local-setup` target accepts the following variables:

| **Makefile Variable** | **Description** | **Default value** |
| --- | --- |--- |
| `GATEWAYAPI_PROVIDER` | GatewayAPI provider name. Accepted values: [*ISTIO*] | *ISTIO* |
| `GATEWAYAPI_PROVIDER` | GatewayAPI provider name. Accepted values: [*istio*] | *istio* |

## Run as a local process

Expand All @@ -41,7 +41,7 @@ The `make local-env-setup` target accepts the following variables:

| **Makefile Variable** | **Description** | **Default value** |
| --- | --- |--- |
| `GATEWAYAPI_PROVIDER` | GatewayAPI provider name. Accepted values: [*ISTIO*] | *ISTIO* |
| `GATEWAYAPI_PROVIDER` | GatewayAPI provider name. Accepted values: [*istio*] | *istio* |

Then, run the operator locally

Expand Down Expand Up @@ -246,8 +246,8 @@ Multiple controller integration tests are defined
| --- | --- | --- | --- |
| `github.com/kuadrant/kuadrant-operator/tests/bare_k8s` | no gateway provider, no GatewayAPI CRDs. Just Kuadrant API and Kuadrant dependencies. | `make local-k8s-env-setup` | `make test-bare-k8s-integration` |
| `github.com/kuadrant/kuadrant-operator/tests/gatewayapi` | no gateway provider. GatewayAPI CRDs, Kuadrant API and Kuadrant dependencies. | `make local-gatewayapi-env-setup` | `make test-gatewayapi-env-integration` |
| `github.com/kuadrant/kuadrant-operator/controllers` | at least one gatewayapi provider. It can be any: istio, envoygateway, ... | `make local-env-setup GATEWAYAPI_PROVIDER=[ISTIO]` (Default *Istio*) | `make test-integration` |
| `github.com/kuadrant/kuadrant-operator/tests/istio` | GatewayAPI CRDs, Istio, Kuadrant API and Kuadrant dependencies. | `make local-env-setup GATEWAYAPI_PROVIDER=ISTIO` | `make test-istio-env-integration` |
| `github.com/kuadrant/kuadrant-operator/controllers` | at least one gatewayapi provider. It can be any: istio, envoygateway, ... | `make local-env-setup GATEWAYAPI_PROVIDER=[istio]` (Default *istio*) | `make test-integration` |
| `github.com/kuadrant/kuadrant-operator/tests/istio` | GatewayAPI CRDs, Istio, Kuadrant API and Kuadrant dependencies. | `make local-env-setup GATEWAYAPI_PROVIDER=istio` | `make test-istio-env-integration` |

### Lint tests

Expand Down
5 changes: 2 additions & 3 deletions make/development-environments.mk
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
##@ Deployment

GATEWAYAPI_PROVIDER = ISTIO
GATEWAYAPI_PROVIDER_LOWERCASE = $(shell echo $(GATEWAYAPI_PROVIDER) | tr A-Z a-z)
GATEWAYAPI_PROVIDER = istio

install: manifests kustomize ## Install CRDs into the K8s cluster specified in ~/.kube/config.
# Use server side apply, otherwise will hit into this issue https://medium.com/pareture/kubectl-install-crd-failed-annotations-too-long-2ebc91b40c7d
Expand Down Expand Up @@ -56,7 +55,7 @@ local-deploy: ## Deploy Kuadrant Operator from the current code

.PHONY: env-setup
env-setup: ## Install deploy kuadrant dependencies and configured gatewayapi provider
$(MAKE) $(GATEWAYAPI_PROVIDER_LOWERCASE)-env-setup ISTIO_INSTALL_SAIL=$(ISTIO_INSTALL_SAIL)
$(MAKE) $(GATEWAYAPI_PROVIDER)-env-setup ISTIO_INSTALL_SAIL=$(ISTIO_INSTALL_SAIL)

.PHONY: local-env-setup
local-env-setup: ## env-setup based on kind cluster
Expand Down

0 comments on commit 5812c99

Please sign in to comment.