Skip to content

Commit

Permalink
Start subnet offset at 1 to avoid overlap with kind cluster ips
Browse files Browse the repository at this point in the history
  • Loading branch information
david-martin committed May 28, 2024
1 parent 71c797f commit 3cd0fa9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ deploy-dependencies: kustomize dependencies-manifests ## Deploy dependencies to
kubectl -n "$(KUADRANT_NAMESPACE)" wait --timeout=300s --for=condition=Available deployments --all

.PHONY: install-metallb
install-metallb: SUBNET_OFFSET=0
install-metallb: SUBNET_OFFSET=1
install-metallb: kustomize yq ## Installs the metallb load balancer allowing use of an LoadBalancer type with a gateway
$(KUSTOMIZE) build config/metallb | kubectl apply -f -
kubectl -n metallb-system wait --for=condition=Available deployments controller --timeout=300s
Expand Down
4 changes: 2 additions & 2 deletions hack/quickstart-setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export CONTAINER_RUNTIME_BIN=$(containerRuntime)
export KIND_BIN=kind
export HELM_BIN=helm
export KUSTOMIZE_BIN=$(dockerBinCmd "kustomize")
export SUBNET_OFFSET=0
export SUBNET_OFFSET=1
export HUB=1

YQ_BIN=$(dockerBinCmd "yq")
Expand Down Expand Up @@ -402,7 +402,7 @@ if cluster_exists "${KUADRANT_CLUSTER_NAME}"; then
next_cluster_number=$((last_number + 1))
fi
KUADRANT_CLUSTER_NAME="${KUADRANT_CLUSTER_NAME}-${next_cluster_number}"
SUBNET_OFFSET=${next_cluster_number}
SUBNET_OFFSET=$((SUBNET_OFFSET + 1))
HUB=0
echo "Next cluster number will be ${KUADRANT_CLUSTER_NAME}."
read -r -p "Is it okay to create the cluster '${KUADRANT_CLUSTER_NAME}'? (y/N): " confirm </dev/tty
Expand Down

0 comments on commit 3cd0fa9

Please sign in to comment.