Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing glob imports, added script to detect dangling imports #188

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

jasonmadigan
Copy link
Member

@jasonmadigan jasonmadigan commented Jan 24, 2025

  • Cleanup dangling imports, remove globs
  • removing glob imports, added script to detect dangling imports, generates explicit multirepo imports from the nav:
    • Can be run manually: python3 validate_imports.py

Copy link
Contributor

openshift-ci bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonmadigan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jasonmadigan jasonmadigan changed the title script to detect dangling imports, generates explicit multirepo imports from the nav removing glob imports, added script to detect dangling imports Jan 24, 2025
Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for graceful-kangaroo-3c9c10 ready!

Name Link
🔨 Latest commit a0c3b1f
🔍 Latest deploy log https://app.netlify.com/sites/graceful-kangaroo-3c9c10/deploys/67937f0d7633e700086f6ed3
😎 Deploy Preview https://deploy-preview-188--graceful-kangaroo-3c9c10.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jasonmadigan jasonmadigan marked this pull request as draft January 24, 2025 10:32
@jasonmadigan jasonmadigan force-pushed the 181-remove-dangling-docs branch from be6536c to 152774d Compare January 24, 2025 10:48
@jasonmadigan jasonmadigan force-pushed the 181-remove-dangling-docs branch from 152774d to a0c3b1f Compare January 24, 2025 11:52
@jasonmadigan jasonmadigan marked this pull request as ready for review January 24, 2025 11:54
@jasonmadigan
Copy link
Member Author

jasonmadigan commented Jan 24, 2025

@david-martin fyi - ready for review. I did keep some of the image globs in the end, but none of the doc ones.

@david-martin
Copy link
Member

👀

@david-martin
Copy link
Member

/lgtm

This highlights the high number of files that are still being published because they are linked to, but don't have a location in the nav.
Looks to be primarily docs pulled in from the authorino repo, and linked from the '/docs/user-guides/observability.md' file

The changes in the PR are sufficient to satisfy #181.
There is ongoing discussion around authorino content, and that observability file, which may lead to some further cleanup.

@openshift-ci openshift-ci bot added the lgtm label Jan 24, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 3fe63fb into main Jan 24, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants