Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for mermaid diagrams #111

Merged
merged 1 commit into from
May 14, 2024
Merged

Support for mermaid diagrams #111

merged 1 commit into from
May 14, 2024

Conversation

jasonmadigan
Copy link
Member

@jasonmadigan jasonmadigan commented May 14, 2024 •
edited
Loading

Resolves #107

@openshift-ci openshift-ci bot requested review from david-martin and R-Lawton May 14, 2024 13:48
@netlify Netlify
Copy link

netlify bot commented May 14, 2024 •
edited
Loading

✅ Deploy Preview for graceful-kangaroo-3c9c10 ready!

Name Link
🔨 Latest commit eeb1d54
🔍 Latest deploy log https://app.netlify.com/sites/graceful-kangaroo-3c9c10/deploys/66436bb3ef5b9600085c6d6b
😎 Deploy Preview https://deploy-preview-111--graceful-kangaroo-3c9c10.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jasonmadigan
Copy link
Member Author

Example: https://deploy-preview-111--graceful-kangaroo-3c9c10.netlify.app/architecture/rfcs/0009-defaults-and-overrides/#apply-policies-to-a-gateway-root-object-and-all-objects-beneath

@jasonmadigan
Copy link
Member Author

@guicassolato

guicassolato
guicassolato approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@guicassolato guicassolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve /lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guicassolato, jasonmadigan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [guicassolato,jasonmadigan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jasonmadigan jasonmadigan merged commit 7904f67 into main May 14, 2024
8 of 9 checks passed
@jasonmadigan jasonmadigan deleted the mermaid-diagrams branch September 20, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guicassolato guicassolato guicassolato approved these changes

@david-martin david-martin Awaiting requested review from david-martin

@R-Lawton R-Lawton Awaiting requested review from R-Lawton

Assignees
No one assigned
Labels
approved
Projects
Kuadrant
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Mermaid diagrams
2 participants
@jasonmadigan @guicassolato