Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rootHost to DNS Record spec #50

Closed
philbrookes opened this issue Mar 7, 2024 · 1 comment
Closed

Add rootHost to DNS Record spec #50

philbrookes opened this issue Mar 7, 2024 · 1 comment
Assignees
@maleck13
Labels
good first issue Good for newcomers size/small

Comments

@philbrookes
Copy link
Collaborator

philbrookes commented Mar 7, 2024 •
edited by mikenairn
Loading

What

Add new optional field to the DNSRecord spec called "rootHost" and update DNSRecord creation to set that as the listener hostname.

If that field is present, all hosts in that DNS Record must be either subdomains of the rootHost or be the rootHost.
@philbrookes philbrookes mentioned this issue Mar 7, 2024
Closed
19 tasks
@mikenairn mikenairn changed the title Add root host to DNS Record spec Add rootHost to DNS Record spec Mar 7, 2024
@mikenairn mikenairn mentioned this issue Mar 7, 2024
Closed
20 tasks
@mikenairn mikenairn moved this to Todo in Kuadrant Mar 7, 2024
@mikenairn mikenairn mentioned this issue Mar 7, 2024
Merged
@philbrookes philbrookes added the good first issue Good for newcomers label Mar 11, 2024
@maleck13 maleck13 self-assigned this Mar 11, 2024
@maleck13 maleck13 moved this from Todo to In Progress in Kuadrant Mar 11, 2024
@maleck13
Copy link
Collaborator

hmm so I am thinking we add the optional property first then we might want to bump a release of dns operator? then update Kuadrant Operator?

@maleck13 maleck13 moved this from In Progress to Ready For Review in Kuadrant Mar 11, 2024
maleck13 added a commit that referenced this issue Mar 14, 2024
@maleck13
Merge pull request #55 from Kuadrant/gh-50
6144e5f 
add optional rootHost
@maleck13 maleck13 moved this from Ready For Review to Done in Kuadrant Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maleck13 maleck13

Labels
good first issue Good for newcomers size/small
Projects
Kuadrant
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maleck13 @philbrookes