Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Authorino Operator metrics service #187

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

guicassolato
Copy link
Collaborator

@guicassolato guicassolato commented Jun 28, 2024

Closes #185

Verification steps

kind create cluster
make deploy install

Check the metrics service exists:

$ kubectl get services -n authorino-operator
NAME                         TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)    AGE
authorino-operator-metrics   ClusterIP   10.96.142.214   <none>        8080/TCP   47s
authorino-webhooks           ClusterIP   10.96.30.52     <none>        443/TCP    20s

@guicassolato guicassolato requested a review from R-Lawton June 28, 2024 13:09
@guicassolato guicassolato self-assigned this Jun 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.78%. Comparing base (a07ac74) to head (c9d0e99).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #187   +/-   ##
=======================================
  Coverage   61.78%   61.78%           
=======================================
  Files           2        2           
  Lines         785      785           
=======================================
  Hits          485      485           
  Misses        249      249           
  Partials       51       51           
Flag Coverage Δ
unit 61.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@R-Lawton
Copy link

Do you want to also add the change i had in the other pr with the makefile stopping controller-gen SIGSEGV panic

@guicassolato
Copy link
Collaborator Author

guicassolato commented Jun 28, 2024

Do you want to also add the change i had in the other pr with the makefile stopping controller-gen SIGSEGV panic

Is that an environment-specific issue? I could run make manifests bundle just fine locally.

@R-Lawton
Copy link

No it wasnt just my machine I got Jason to run the same commands and he ran into the issue to

@guicassolato
Copy link
Collaborator Author

No it wasnt just my machine I got Jason to run the same commands and he ran into the issue to

I'm so sorry, @R-Lawton. You are absolutely right!

After rm -rf ./bin/*, I also see the SIGSEGV. I guess my controller-gen was outdated. Pushing your fix now...

Makefile Outdated Show resolved Hide resolved
Copy link

@R-Lawton R-Lawton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@guicassolato guicassolato merged commit 9560c40 into main Jul 1, 2024
8 checks passed
@guicassolato guicassolato deleted the metrics-service branch July 1, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

BUG: Authorino operator metrics service isnt being created
3 participants