Remove extra quotes in tracing tags

[adam-cattermole]

Tested with new image built from this (quay.io/acatterm/authorino-operator:fix-tracing-tags):

Authorino CR spec:

spec:
  clusterWide: true
  healthz: {}
  listener:
    ports: {}
    tls:
      enabled: false
  metrics: {}
  oidcServer:
    tls:
      enabled: false
  supersedingHostSubsets: true
  tracing:
    endpoint: rpc://jaeger-collector.istio-system.svc.cluster.local:4317
    insecure: true
    tags:
      random-key: random-value
      test-key: test-value
  volumes: {}

Resolves #171

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0796bc) 61.78% compared to head (638fbdc) 61.78%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #172   +/-   ##
=======================================
  Coverage   61.78%   61.78%           
=======================================
  Files           2        2           
  Lines         785      785           
=======================================
  Hits          485      485           
  Misses        249      249           
  Partials       51       51           

Flag	Coverage Δ
unit	61.78% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[guicassolato]

Have you tested with tag values containing white spaces?

spec:
  tracing:
    tags:
      tag-with-white-space: value with spaces

Maybe also a key containing white spaces:

spec:
  tracing:
    tags:
      "tag key with spaces": some-value

I wonder if it could break the deployment.

[adam-cattermole]

Yep tested now:

tracing:
  endpoint: rpc://jaeger-collector.istio-system.svc.cluster.local:4317
  insecure: true
  tags:
    key with spaces: value with spaces
    test-key: test-value

spec:
  containers:
  - args:
    - --allow-superseding-host-subsets
    - --tracing-service-endpoint=rpc://jaeger-collector.istio-system.svc.cluster.local:4317
    - --tracing-service-insecure
    - --tracing-service-tag=key with spaces=value with spaces
    - --tracing-service-tag=test-key=test-value

[guicassolato]

I see no reason now for keeping the usage of trim functions in the tests:

authorino-operator/controllers/authorino_controller_test.go

Line 355 in b0796bc

kv := strings.Split(strings.TrimPrefix(strings.TrimSuffix(value, `"`), `"`), "=")

WDYT?

[adam-cattermole]

Agreed, removed in commit 00db9df

[guicassolato]

Thanks! 😍