Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MAINTAINERS/ADOPTERS files #165

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Adding MAINTAINERS/ADOPTERS files #165

merged 1 commit into from
Feb 21, 2024

Conversation

guicassolato
Copy link
Collaborator

No description provided.

@guicassolato guicassolato self-assigned this Jan 12, 2024
@guicassolato guicassolato marked this pull request as draft January 12, 2024 09:54
@guicassolato guicassolato force-pushed the maintainers branch 2 times, most recently from 25ebf9e to e2b1598 Compare February 20, 2024 14:44
@guicassolato guicassolato requested a review from a team February 20, 2024 16:41
@guicassolato guicassolato marked this pull request as ready for review February 20, 2024 16:41
ADOPTERS Outdated
Copy link
Contributor

@KevFan KevFan Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Should these files be using .md extension like in https://github.com/Kuadrant/authorino ? 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks.

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (03b4263) 61.78% compared to head (ed87bf8) 61.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   61.78%   61.78%           
=======================================
  Files           2        2           
  Lines         785      785           
=======================================
  Hits          485      485           
  Misses        249      249           
  Partials       51       51           
Flag Coverage Δ
unit 61.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@didierofrivia didierofrivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👯

@guicassolato guicassolato merged commit 99e413d into main Feb 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants