Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Semi implement #728, with points 2 & 4 outstanding #730

Merged
merged 7 commits into from
Jun 11, 2022
Merged

Conversation

PWagner1
Copy link
Contributor

@PWagner1 PWagner1 commented Jun 6, 2022

@PWagner1 PWagner1 requested a review from Smurf-IV June 6, 2022 07:57
@PWagner1 PWagner1 requested a review from Smurf-IV June 6, 2022 08:34
@PWagner1
Copy link
Contributor Author

Resolved conflicts

@Smurf-IV
Copy link
Member

Smurf-IV commented Jun 11, 2022

Resolved conflicts

Still need to resolve the last 2 Review comments. (And the conflict)

@PWagner1
Copy link
Contributor Author

Resolved conflicts

Still need to resolve the last 2 Review comments. (And the conflict)

Done :)

@Smurf-IV Smurf-IV merged commit 66e42f7 into alpha Jun 11, 2022
@PWagner1 PWagner1 deleted the alpha-fr#728 branch June 11, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants