Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Can ButtonSpecs support dropdown menus #962

Closed
PWagner1 opened this issue Mar 6, 2023 · 6 comments
Closed

[Feature Request]: Can ButtonSpecs support dropdown menus #962

PWagner1 opened this issue Mar 6, 2023 · 6 comments
Labels
completed This issue has been completed. enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested.

Comments

@PWagner1
Copy link
Contributor

PWagner1 commented Mar 6, 2023

Can ButtonSpecs support dropdown menus, like split buttons?
@PWagner1 PWagner1 added enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested. labels Mar 6, 2023
@Smurf-IV
Copy link
Member

Smurf-IV commented Mar 7, 2023

This would need to be a "new" type of button because:

  • it is wider
  • it needs different actions dependant on where the click happens
  • Needs to be "Finger size" friendly

I suggest just having an Drop down button image, and attach a menu to the "underside" when clicked. I think that is already possible.

@PWagner1
Copy link
Contributor Author

PWagner1 commented Mar 7, 2023

The reason is due to the new undo & redo options. The developer may want to include the history

@SmartSuperAppSuperApp
Copy link

Like I mean: Help design form

@Smurf-IV
Copy link
Member

Smurf-IV commented Aug 1, 2023

The simplest way would be to have

  • an additional Style to the buttonSpec,
  • that draws a split type image on the button left,
  • that has the same height and style as the a Cluster button (i.e. does not have rounded edges when combined with the previous button it's edge(s))
    image

@Smurf-IV Smurf-IV self-assigned this Aug 1, 2023
@Smurf-IV Smurf-IV added the in progress A fix for this issue is in the works. label Aug 1, 2023
@Smurf-IV
Copy link
Member

Smurf-IV commented Aug 2, 2023

Coming to a PR Soon:
ButtonSpecDropDown

@Smurf-IV
Copy link
Member

Smurf-IV commented Aug 2, 2023

And showing an undo style:
image

Smurf-IV added a commit that referenced this issue Aug 2, 2023
@Smurf-IV
- Implement the dropDown and actions for ButtonSpecAny
3f882e9 
- Some more nullable catches
- Some spelling

#962
@Smurf-IV Smurf-IV mentioned this issue Aug 2, 2023
Merged
Smurf-IV added a commit to Krypton-Suite/Standard-Toolkit-Demos that referenced this issue Aug 2, 2023
@Smurf-IV
- Update example to show dropDown buttonSpec
62c01eb 
for:

#Krypton-Suite/Standard-Toolkit#962
@Smurf-IV Smurf-IV mentioned this issue Aug 2, 2023
Merged
@Smurf-IV Smurf-IV closed this as completed Aug 2, 2023
@Smurf-IV Smurf-IV removed their assignment Aug 2, 2023
@Smurf-IV Smurf-IV added completed This issue has been completed. and removed in progress A fix for this issue is in the works. labels Aug 2, 2023
Smurf-IV added a commit that referenced this issue Aug 3, 2023
@Smurf-IV
- Fix Exception when using different types of ButtonSpec
e6b2606 
#962
@Smurf-IV Smurf-IV mentioned this issue Aug 3, 2023
Merged
@PWagner1 PWagner1 mentioned this issue Jun 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
completed This issue has been completed. enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested.
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

alpha-962-ButtonSpecsDropdown Krypton-Suite/Standard-Toolkit
3 participants
@PWagner1 @Smurf-IV @SmartSuperAppSuperApp