Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Other Issues]: As this project is now a long way from the original "ComponentFactory" - The BSD3 License Header needs to change #60

Closed
Smurf-IV opened this issue Mar 27, 2021 · 4 comments
Labels
discussion Discussion thread. fixed This issue has been fixed. other All other issues.

Comments

@Smurf-IV
Copy link
Member

re the following in each source file:

// *****************************************************************************
// BSD 3-Clause License (https://github.com/ComponentFactory/Krypton/blob/master/LICENSE)
//  © Component Factory Pty Ltd, 2006 - 2016, All rights reserved.
// The software and associated documentation supplied hereunder are the 
//  proprietary information of Component Factory Pty Ltd, 13 Swallows Close, 
//  Mornington, Vic 3931, Australia and are supplied subject to license terms.
// 
//  Modifications by Peter Wagner(aka Wagnerp) & Simon Coghlan(aka Smurf-IV), et al. 2017 - 2021. All rights reserved. (https://github.com/Krypton-Suite/Standard-Toolkit)
//  Version 6.0.0  
// *****************************************************************************

Perhaps something like this:

// *****************************************************************************
// Original BSD 3-Clause License (https://github.com/ComponentFactory/Krypton/blob/master/LICENSE)
//  © Component Factory Pty Ltd, 2006 - 2016, All rights reserved.
// 
//  New BSD 3-Clause License (https://github.com/Krypton-Suite/Standard-Toolkit/blob/master/LICENSE)
//  Modifications by Peter Wagner(aka Wagnerp) & Simon Coghlan(aka Smurf-IV), et al. 2017 - 2021. All rights reserved. 
//  Version 6.0.0  
// *****************************************************************************

i.e. reduce the impact of the original, because it sort of looks like "we" work for ComponentFactory at first glance.

@Smurf-IV Smurf-IV added discussion Discussion thread. other All other issues. labels Mar 27, 2021
@Smurf-IV Smurf-IV changed the title [Other Issues]: As this project is now a long way from the original "ComponentFactory" - The BSDF License Header needs to change [Other Issues]: As this project is now a long way from the original "ComponentFactory" - The BSD3 License Header needs to change Mar 27, 2021
@PWagner1
Copy link
Contributor

Could use the License Header extension for VS to change this. See extended toolkit for an example.

@PWagner1 PWagner1 self-assigned this Mar 28, 2021
@PWagner1 PWagner1 added in progress A fix for this issue is in the works. under investigation This bug/issue is currently under investigation. labels Mar 28, 2021
@PWagner1
Copy link
Contributor

Does the version of the toolkit really need to be included in the header?

PWagner1 added a commit that referenced this issue Mar 28, 2021
@PWagner1 PWagner1 added fixed This issue has been fixed. and removed in progress A fix for this issue is in the works. under investigation This bug/issue is currently under investigation. labels Mar 28, 2021
@PWagner1 PWagner1 removed their assignment Mar 28, 2021
@Smurf-IV
Copy link
Member Author

Smurf-IV commented Apr 9, 2021

Does the version of the toolkit really need to be included in the header?

No , but I think the modification date(s) do for BSD.

@PWagner1
Copy link
Contributor

Implemented in build 2106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion thread. fixed This issue has been fixed. other All other issues.
Projects
None yet
Development

No branches or pull requests

2 participants