Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Office 365 - Black (Dark mode) Messes up combo boxes #237

Closed
Smurf-IV opened this issue Aug 4, 2021 · 14 comments
Closed

[Bug]: Office 365 - Black (Dark mode) Messes up combo boxes #237

Smurf-IV opened this issue Aug 4, 2021 · 14 comments
Labels
area:themes All things to do with themes. bug Something isn't working completed This issue has been completed. fixed This issue has been fixed.
Milestone

Comments

@Smurf-IV
Copy link
Member

Smurf-IV commented Aug 4, 2021

image

@Smurf-IV Smurf-IV added bug Something isn't working area:themes All things to do with themes. labels Aug 4, 2021
@Smurf-IV
Copy link
Member Author

Smurf-IV commented Aug 4, 2021

Same for the Office 2010 - Black (Dark Mode)

@Smurf-IV
Copy link
Member Author

Smurf-IV commented Aug 4, 2021

And Office 2007 - Black (Dark Mode)

@PWagner1
Copy link
Contributor

@Smurf-IV Is there a value that controls the CB dropdown background?

@Smurf-IV
Copy link
Member Author

Yes
image

And there is also the equivalent in the ComboBox back as well.

The Palette designer should have these as visible entities to check

@PWagner1
Copy link
Contributor

Yes
image

And there is also the equivalent in the ComboBox back as well.

The Palette designer should have these as visible entities to check

Ok, just need to decipher what value it is in the 'built-in palettes'

@PWagner1 PWagner1 self-assigned this Sep 20, 2021
@PWagner1 PWagner1 added help wanted Extra attention is needed under investigation This bug/issue is currently under investigation. labels Sep 20, 2021
@PWagner1
Copy link
Contributor

I've worked out what controls it, but not the variable to change... yet!

image

@PWagner1
Copy link
Contributor

I'm confused... I thought the following would operate it, but no it doesn't

Color.Black,                      // InputDropDownNormal1
Color.Transparent,                // InputDropDownNormal2

?

@PWagner1
Copy link
Contributor

@Smurf-IV How did you setup the colours for #138?

@Smurf-IV
Copy link
Member Author

@Smurf-IV How did you setup the colours for #138?

138 has nothing to do with colours.. Another number ?

@PWagner1
Copy link
Contributor

@Smurf-IV How did you setup the colours for #138?

138 has nothing to do with colours.. Another number ?

I don't think that colours from the base palettes were wired in, could you have a look please? :)

@Smurf-IV
Copy link
Member Author

@Smurf-IV How did you setup the colours for #138?

138 has nothing to do with colours.. Another number ?

I don't think that colours from the base palettes were wired in, could you have a look please? :)

Again, what has 138 (Drag'n'Drop listview) got to do colours ?

@PWagner1
Copy link
Contributor

@Smurf-IV How did you setup the colours for #138?

138 has nothing to do with colours.. Another number ?

I don't think that colours from the base palettes were wired in, could you have a look please? :)

Again, what has 138 (Drag'n'Drop listview) got to do colours ?

I was thinking about the background of the item

image

I just can't find where the dropdown code is handled.

@PWagner1 PWagner1 added this to the January 2022 milestone Nov 1, 2021
@PWagner1
Copy link
Contributor

PWagner1 commented Nov 1, 2021

Finally, found the code that handles combobox drop down colours! :)

@PWagner1 PWagner1 added in progress A fix for this issue is in the works. and removed help wanted Extra attention is needed under investigation This bug/issue is currently under investigation. labels Nov 2, 2021
@PWagner1 PWagner1 mentioned this issue Nov 2, 2021
Smurf-IV added a commit that referenced this issue Nov 3, 2021
@PWagner1 PWagner1 removed their assignment Nov 3, 2021
@PWagner1 PWagner1 added completed This issue has been completed. fixed This issue has been fixed. and removed in progress A fix for this issue is in the works. labels Nov 3, 2021
@PWagner1
Copy link
Contributor

PWagner1 commented Nov 3, 2021

Fixed in build 2201.

@PWagner1 PWagner1 closed this as completed Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:themes All things to do with themes. bug Something isn't working completed This issue has been completed. fixed This issue has been fixed.
Projects
None yet
Development

No branches or pull requests

2 participants