Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request/Bug]: Tracking colours need reviewing #1528

Closed
PWagner1 opened this issue Jun 15, 2024 · 13 comments
Closed

[Feature Request/Bug]: Tracking colours need reviewing #1528

PWagner1 opened this issue Jun 15, 2024 · 13 comments
Labels
area:themes All things to do with themes. area:toolkit All issues related to the toolkit components. enhancement New feature or request fixed This issue has been fixed. new feature A new feature has been requested. suggestion A suggestion has been requested. under investigation This bug/issue is currently under investigation. version:85-lts All things to do with V85 LTS. version:90 All things to do with V90.

Comments

@PWagner1
Copy link
Contributor

Following discussions from #619, the tracking colours may need reviewing.

@PWagner1 PWagner1 added enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested. area:themes All things to do with themes. area:toolkit All issues related to the toolkit components. labels Jun 15, 2024
@PWagner1 PWagner1 self-assigned this Jun 17, 2024
@PWagner1 PWagner1 added the under investigation This bug/issue is currently under investigation. label Jun 17, 2024
@PWagner1 PWagner1 added this to the Version 85 milestone Jun 17, 2024
@PWagner1
Copy link
Contributor Author

Hi @giduac & @Smurf-IV

Planning to use lighter colours (for dark modes).

@PWagner1
Copy link
Contributor Author

PWagner1 commented Jun 18, 2024

Hi @Smurf-IV & @giduac

Progress...

image

@PWagner1
Copy link
Contributor Author

PWagner1 commented Jun 20, 2024

Hi @Smurf-IV & @giduac

For v100, I'm planning to completely redo the dark silver themes using these palettes

shades-x11-color-silver-c0c0c0-hex-31578-colorswall

or

5 _Dark_Gray_Color_Palette_Color_Palette_with_Night_Hex_111111_Eerie_Black_Hex_232323_Jet_Hex_343434_Outer_Space_Hex_464646_Davy_S_Gray_Hex_575757_Color_Palette_with_Hex_Codes

or

71706E59585641403F2B2A29171614000000

Thoughts?

@Smurf-IV
Copy link
Member

Not sure, Just a note, The existing dark themes have messed up the tracking of the Hover over drop button on ComboBox's

@PWagner1
Copy link
Contributor Author

Not sure, Just a note, The existing dark themes have messed up the tracking of the Hover over drop button on ComboBox's

Hi @Smurf-IV

That might need to be a separate bug, as the drop-down arrow thing is not legible on other themes as well! Do we know if this is controlled by a colour, or is it a image?

@giduac
Copy link
Contributor

giduac commented Jun 20, 2024

Reference in

That's a lot of work at the moment
If it's only the drop button my choice would be to fix it.

We have lot of work already which we need to get a grip on imo.

@PWagner1
Copy link
Contributor Author

Reference in

That's a lot of work at the moment If it's only the drop button my choice would be to fix it.

We have lot of work already which we need to get a grip on imo.

I'll create a new bug report.

@giduac
Copy link
Contributor

giduac commented Jun 20, 2024

Also I think that these are pretty good.
Creating a copy or new one with those new colors is also an option.

Another thought: when using a new version devs are not confronted with a changed theme (a bit of a breaking change) which can be undesirable...

@PWagner1
Copy link
Contributor Author

Also I think that these are pretty good. Creating a copy or new one with those new colors is also an option.

Another thought: when using a new version devs are not confronted with a changed theme (a bit of a breaking change) which can be undesirable...

The problem is that the current iteration is too 'blue' in my opinion.

@PWagner1
Copy link
Contributor Author

Dark blue: https://colorswall.com/palette/8

Light blue (alternate): https://colorswall.com/palette/13

@giduac
Copy link
Contributor

giduac commented Jun 20, 2024

Also I think that these are pretty good. Creating a copy or new one with those new colors is also an option.
Another thought: when using a new version devs are not confronted with a changed theme (a bit of a breaking change) which can be undesirable...

The problem is that the current iteration is too 'blue' in my opinion.

Well even if there are a lot of blue themes it's still a user's choice to use them or not.

To catch up with current trends I would go for a set of new themes that are minimalistic and approach Material Design as much as possible. So Winforms apps can stay on par with other strong UI trends.

@giduac
Copy link
Contributor

giduac commented Jun 20, 2024

@Wagnerp & @Smurf-IV

Adding to the above my view on the current state of KT:

  • Currently there are more than 60 bugs open, several for months or longer.
  • There are a lot of tickets addressing (let's call it incompleteness in) themes.
  • Capacity wise we are short of man power.
  • That all leaves no room for new features atm.

If we don't get a grip on the current state and keep adding new features to the kit which in turn cause more work it will only get out of control further.

My thoughts are to first stop adding new stuff for now and finish what there is.
Draw up rules by which we work and more important react to situations.

For example introduce a max open bug count 5 or 10. If that number is reached more capacity will be directed to solving them.

Introduction of new features only via a plan that is draw up by us and agreed upon by all, so we:

  • know what to work on
  • what the outcome will be
  • we can measure how far a new feature has progressed
  • when done, test if it does what what it should.

@PWagner1
Copy link
Contributor Author

Hi @giduac

The alternate silver mode themes can be tacked on to the v100 milestone. However to avoid losing the colour swatches, a new feature request will need to be opened.

@PWagner1 PWagner1 added the version:85-lts All things to do with V85 LTS. label Jun 21, 2024
PWagner1 added a commit that referenced this issue Jun 22, 2024
PWagner1 added a commit that referenced this issue Jun 23, 2024
@PWagner1 PWagner1 added the version:90 All things to do with V90. label Aug 11, 2024
@PWagner1 PWagner1 removed their assignment Aug 11, 2024
@PWagner1 PWagner1 added the fixed This issue has been fixed. label Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:themes All things to do with themes. area:toolkit All issues related to the toolkit components. enhancement New feature or request fixed This issue has been fixed. new feature A new feature has been requested. suggestion A suggestion has been requested. under investigation This bug/issue is currently under investigation. version:85-lts All things to do with V85 LTS. version:90 All things to do with V90.
Projects
None yet
Development

No branches or pull requests

3 participants