[Bug]: Button Spec Krypton Context Menu (Canary)

[sdreb3421]

Using Winforms NET6 with VS2022 on Windows 11.

Recently upgraded to Canary 80.23.10.296 and found an issue with Button Spec context menus. Did some checking and the issue appears in Canary 80.23.8.233. The KryptonForm ButtonSpec property KryptonContextMenu is assigned a KryptonContextMenu object, but the menu no longer appears when clicking the button. Thanks!

[sdreb3421]

Will this fix be captured in the new NET 8 release? Thanks

[PWagner1]

Will this fix be captured in the new NET 8 release? Thanks

No, but this will be fixed in a future v90 release

[sdreb3421]

I know you guys are a small team, but you guys tend to introduce more issues than you fix. Context menus are fundamental.

[PWagner1]

I know you guys are a small team, but you guys tend to introduce more issues than you fix. Context menus are fundamental.

Hi @sdreb3421 Is the issue with the KryptonForm or the KryptonContextMenu, as I've had a look at the alpha code and it seems to be ok?

[sdreb3421]

I'm not totally sure honestly, it could be either the button or the context menu. I have a KryptonForm with multiple ButtonSpecAny (ButtonSpecs Collection) in the title bar. Within the ButtonSpecAny designer properties I have assigned a KryptonContextMenu to the property. However, the menu no longer appears on click starting with Canary 80.23.8.233.

Here is the designer code to validate what is actually happening.
//
// btnFileMenu
//
btnFileMenu.Enabled = ButtonEnabled.True;
btnFileMenu.KryptonContextMenu = menuFile;
btnFileMenu.Text = " File ";

[PWagner1]

@sdreb3421 Would you mind uploading a small project demonstrating the issue, so I can verify what's going on?

[PWagner1]

Wonder if it's defined as null

@Smurf-IV Any ideas?

[sdreb3421]

Here is a simple example of the issue. If you change the nuget package back to 80.23.7.305 then it works again. Thanks!

KryptonContextMenuExample.zip

[PWagner1]

So something happened between the July 2023 & August 2023 releases

[PWagner1]

So, unfortunately I've overwritten the canary branch, but I've decompiled
Version 80237205.zip (last known working version)

[PWagner1]

Hi @sdreb3421

I think that I've narrowed it down to this PR

[sdreb3421]

Ahh, that makes sense. It's probably messing with the button spec clicks somehow.

[Smurf-IV]

I know you guys are a small team, but you guys tend to introduce more issues than you fix. Context menus are fundamental.

Ouch..
That is why the alpha's and canary's get created.
This project is huge, and has a lot of implementations
Testing is done in the area the "Feature / bug" fix is in, but impacts on other parts "may" happen.
We try our best for the time We try to allocate to this unpaid endeavour.

Any way; I'll take a look.

[PWagner1]

Building on @Smurf-IV last comment, any fix implemented won't make its way into v80, both:

A) It needs to be tested
B) If it's injected into master it'll mess up the development 'flow' between canary & alpha because master will be 'ahead' of these

[Smurf-IV]

Also make sure that the default actions still work (i.e. Close button!)

[Smurf-IV]

Note: Workaround for Canary / Master V80 is to add a DropDown, as per the request PR that "Broke" the default.

[sdreb3421]

It's fine honestly. I'll just keep using 80.23.7.305

[PWagner1]

It's fine honestly. I'll just keep using 80.23.7.305

Hi @sdreb3421

The fixes will be included in the next Canary, hopefully targeted for Wednesday with other fixes.

[sdreb3421]

Oh very nice, I didn't realize you found the issue, well done 👍🏼👍🏼👍🏼

[PWagner1]

Oh very nice, I didn't realize you found the issue, well done 👍🏼👍🏼👍🏼

It was to do with the 'new' drop down button spec type. We can't put it into v80, as this would cause 'merge hell' later down the line, with master being ahead of the other testing branches.

[PWagner1]

Hi @sdreb3421

Please retry using canary build >= 326

[sdreb3421]

Working! Thank you, great work