Merge pull request #1525 from giduac/1507-Revise-Theme-Selector-Controls

1507-Revise-Theme-Selector-Controls

Documents/Changelog/Changelog.md

@@ -3,6 +3,14 @@
 =======
 
 ## 2024-11-xx - Build 2411 - November 2024
+* Implemented [#1507](https://github.com/Krypton-Suite/Standard-Toolkit/issues/1507), **[Breaking Change]** `KryptonThemeComboBox`, `KryptonThemeListBox` & `KryptonRibbonGroupThemeComboBox`:
+    - All controls had their code base updated to one standard.
+    - The assignment of themes via an index has been removed from all. 
+    - The previous has been replaced by assignment per PaletteMode identifier.
+    - All controls do now react to theme changes propagated via the KryptonManager. The control will then synchronize the selected item in the list with the newly activated theme.
+    - Form designer files or your code using a theme selector control might hold references to these properties: `KryptonManager`, `ReportSelectedThemeIndex`, `ThemeSelectedIndex` & `SynchronizeDropDownWidth`. These can, safely, be removed.
+    - The DefaultPalette property is now stored in the designer file and if set, the selected palette wil be loaded when the selector control is instantiated. 
+    - The DefaultPalette property can also be used to switch palettes from code.
 * Resolved [#1502](https://github.com/Krypton-Suite/Standard-Toolkit/issues/1502), Fixes some problems creating workspaces introduced through warnings removal.
 * Resolved [#1497](https://github.com/Krypton-Suite/Standard-Toolkit/issues/1497), When pressing ALT to show the Ribbon KeyTips a null reference exception is thrown.
 * Resolved [#1462](https://github.com/Krypton-Suite/Standard-Toolkit/issues/1462), TestForm app: KCombobox from main.cs causes a crash
@@ -15,7 +23,7 @@
 * Resolved [#1475](https://github.com/Krypton-Suite/Standard-Toolkit/issues/1475), Build Scripts will run when no suitable environment is detected. Add 'BinLog' option to `build-*.cmd`
 * Implemented [#1435](https://github.com/Krypton-Suite/Standard-Toolkit/issues/1435), **Breaking Change** Take KMB back to the Winform override (Remove Checkbox etc)
 * Implemented [#1432](https://github.com/Krypton-Suite/Standard-Toolkit/issues/1432), Copy `KryptonMessageBox` to `KryptonMessageBoxDep`
-* Resolved [#1424](https://github.com/Krypton-Suite/Standard-Toolkit/issues/1424), **Breaking Change** `KryptonMessageBox` does not obey tab characters like `MessageBox`
+* Resolved [#1424](https://github.com/Krypton-Suite/Standard-Toolkit/issues/1424), *[Breaking Change]** `KryptonMessageBox` does not obey tab characters like `MessageBox`
 * Resolved [#1381](https://github.com/Krypton-Suite/Standard-Toolkit/issues/1381), **[Regression]** Docking Persistence broken since build ##.23.10.303
 * Resolved [#1301](https://github.com/Krypton-Suite/Standard-Toolkit/issues/1301), **[Regression]** When Maximised - intergrated KryptonRibbon has titlebar issues
 * Resolved [#1383](https://github.com/Krypton-Suite/Standard-Toolkit/issues/1383), Closing last Page in undocked page group prevents addition of further Pages via `KryptonDockingManager.AddToWorkspace` (fix courtesy of [stizler](https://github.com/stigzler))
@@ -604,3 +612,4 @@ Cannot add items to KryptonGroupBox in WinForms Designer
 * Support for .NET Core LTS (currently 3.1)
 * Changed `490` to `500`
 * Builds from now on will be labelled as `YYMM`
+

Source/Krypton Components/Krypton.Ribbon/Group Contents/KryptonRibbonGroupThemeComboBox.cs

@@ -42,7 +42,7 @@ public class KryptonRibbonGroupThemeComboBox : KryptonRibbonGroupComboBox, IKryp
         #region Identity
 
         /// <summary>Initializes a new instance of the <see cref="KryptonRibbonGroupThemeComboBox" /> class.</summary>
-        public KryptonRibbonGroupThemeComboBox()
+        public KryptonRibbonGroupThemeComboBox() : base()
         {
             _manager = new KryptonManager();
             DropDownStyle = ComboBoxStyle.DropDownList;
@@ -61,13 +61,6 @@ public KryptonRibbonGroupThemeComboBox()
 
         #region Public
 
-        // TODO: Deprecated should be removed
-        /// <summary>
-        /// ReportSelectedThemeIndex is deprecated and will be removed.
-        /// </summary>
-        [Browsable(false)]
-        public bool ReportSelectedThemeIndex { get; set; }
-
         /// <inheritdoc/>
         [Category(@"Visuals")]
         [Description(@"The custom assigned palette mode.")]

Source/Krypton Components/Krypton.Toolkit/Controls Toolkit/KryptonThemeComboBox.cs

@@ -55,13 +55,6 @@ public KryptonThemeComboBox()
 
         #region Public
 
-        // TODO: Deprecated should be removed
-        /// <summary>
-        /// ReportSelectedThemeIndex is deprecated and will be removed.
-        /// </summary>
-        [Browsable(false)]
-        public bool ReportSelectedThemeIndex { get; set; }
-
         /// <inheritdoc/>
         [Category(@"Visuals")]
         [Description(@"The custom assigned palette mode.")]

Source/Krypton Components/Krypton.Toolkit/Controls Toolkit/KryptonThemeListBox.cs

@@ -56,13 +56,6 @@ public KryptonThemeListBox()
 
         #region Public
 
-        // TODO: Deprecated should be removed
-        /// <summary>
-        /// ReportSelectedThemeIndex is deprecated and will be removed.
-        /// </summary>
-        [Browsable(false)]
-        public bool ReportSelectedThemeIndex { get; set; }
-
         /// <inheritdoc/>
         [Category(@"Visuals")]
         [Description(@"The custom assigned palette mode.")]

Source/Krypton Components/Krypton.Toolkit/General/CommonHelperThemeSelectors.cs

@@ -212,8 +212,6 @@ internal interface IKryptonThemeSelectorBase
         /// Gets or sets the user defined custom palette.
         /// </summary>
         KryptonCustomPaletteBase? KryptonCustomPalette { get; set; }
-
-        bool ReportSelectedThemeIndex { get; set; }
     }
 
     #endregion