Recover from "scrolling away" from the map #207
Conversation
Resets the viewport of the client back to 0,0
client/src/game/events/keyboard.ts
Outdated
| @@ -68,6 +68,12 @@ export function onKeyDown(event: KeyboardEvent): void { | |||
| event.preventDefault(); | |||
| event.stopPropagation(); | |||
| gameStore.toggleUI(); | |||
| } else if (event.key === "r" && event.ctrlKey) { | |||
There was a problem hiding this comment.
Ctrl+R is a common keybinding to reload a webpage and I would thus prefer not to override it, as it could be that a user wants to actually hard reload the page if something seems wrong. I would either choose a different combo (be it a different modifier or letter) or even just use the R key without any modifier.
There was a problem hiding this comment.
You're right. But it's difficult to find one that's really unique and maybe not in use by other apps. In the most ideal situation you'd let the user pick a combo. I wouldn't use a non-modified letter since that might interfere with typing actions during 'normal' operations.
There was a problem hiding this comment.
I understand the sentiment, but this is something that should already be properly handled. The 'd' key deselects the current selection, but not if the user is typing in a textfield/textarea as can be seen in lines 21-23
client/src/game/events/keyboard.ts
Outdated
| gameStore.setPanX(0); | ||
| gameStore.setPanY(0); | ||
| sendClientOptions(gameStore.locationOptions); | ||
| window.location.reload(); |
There was a problem hiding this comment.
This unnecessarily reloads the entire page including all the data transfers and bootup logic.
What you want to do instead is tell the canvas to rerender, which you do by telling the various layers that they are no longer valid with: layerManager.invalidate()
(this just pertains to the window.location.reload() line, the other lines are required. I messed up the selection apparently)
There was a problem hiding this comment.
Ok, I've updated the code. CTRL-0 (zero) is now the hot-key and the layermanager invalidated. No more reloads. BTW, if I want to write some settings to the db, how would I approach this? (Think user settings/key settings etc) This might also help with #178. I can have a look at this combination if you want.
|
This looks good to go, one last thing I forgot to mention is to update the CHANGELOG file in the root of the repository with your change. Feel free to add something like [contributed by LDeeJay1969 or something at the end of the line. |
Resets the viewport of the client back to 0,0