bug(NoteManager): Fix search options dialog not overlapping some elements #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1505 the z-index property was removed from the div inside #note-search, which corrected the issue of the searchbar rendering overtop other modals. However, it introduced the problem of having the headers of the note listing render overtop the search options dialog.
I addressed this issue by reintroducing the z-index, but only to the settings dialog. This of course reintroduced part of the original problem from #1495, as well as making the dialog render overtop its own toggle control button. So I add a copy of the toggle to the dialog and make the original toggle button no longer
position: absolutesince there's no point to doing so anymore.This left the issue of the dialog still drawing over other modals when they were moved to its position. I decided to solve this in a way that would solve another of my gripes. I call this a dialog window because that's how it feels to me; it should only be open for a short while and close as soon as it loses focus. By having the dialog close when it loses "focus", it will no longer draw over anything it shouldn't because it's already closed! This feels much better to me in general and it solves the render order drawing issue.
This completes solving #1495.