bug(Character): Fix multiple variant bugs #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variants/ToggleComposites are a common source of issues and the character system wanted to experience this as well.
This PR closes a bunch of bugs related to the use of shapes with variants as characters.
Variants are completely separate shapes behind the scenes currently and only one of them is getting marked as a character, which ended up causing funky bugs when another variant is active and you try to interact with the character system. This ranged from not being able to move a character by dropping it using the menu to actually removing shapes when deleting them instead of preserving them for later use.
This PR mostly prevents issues with shapes that are not bugged yet. So if you have some weird shenanigans already going on, you might have to remake the shape/character and get rid of the old ones.
As the variants system often introduces issues I'm likely going to do an overhaul to the entire shape system in the release following the next one so that these kind of issues are no longer a thing or will be caught way earlier.