Named connection strings - using standard ConnectionStrings section in appsettings.json #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Burgyn
reviewed
Jul 10, 2019
satano
changed the title
satano
changed the title
Burgyn
reviewed
Jul 25, 2019
| /// </summary> | ||
| /// <param name="factory">Database factory.</param> | ||
| /// <returns>Database instance.</returns> | ||
| public static IDatabase GetDatabase(this IDatabaseFactory factory) |
There was a problem hiding this comment.
Why this method is like extension method and not directly in interface?
|
|
||
| services.AddKorm("server=localhost-1", "db1"); | ||
| services.AddKorm("server=localhost-2"); | ||
| services.AddKorm("server=localhost-3", "db3"); |
There was a problem hiding this comment.
Why this connection string with name db3 is added? It is not used.
| action.Should().Throw<ArgumentException>().And.ParamName.Should().Be("name"); | ||
| } | ||
|
|
||
| [Fact] |
There was a problem hiding this comment.
I would add one test to verify that IDatabase instance is disposed after the scope ended.
| throw new ArgumentException(string.Format(Resources.DuplicateDatabaseName, name), nameof(name)); | ||
| } | ||
| builders.Add(name, builder); | ||
| return builders.Count == 1; |
There was a problem hiding this comment.
This is very confusing for me. When the method Add.. returns a boolean, I assume that return true is if item added successfully. I looked at it for a long time, as long as I understood.
Burgyn
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4