Project for docs. #131
Merged
Project for docs. #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I guess the docker image is Julia v1.0.0? Would it be possible to update that to v1.0.1 which includes JuliaLang/julia#28625? It is a trivial workaround that I will include for now. |
|
Will update the docker image. |
fredrikekre
force-pushed
the
fe/docs
branch
3 times, most recently
from
6dde61e to
4b58b0e
Compare
fredrikekre
commented
Nov 8, 2018
|
|
||
| # save coverage results back to host | ||
| PKGDIR=`$JULIABIN -e "import Pkg, $PKGNAME; print(joinpath(dirname(pathof($PKGNAME)), ".."))"` | ||
| rsync -mav --include="*/" --include="*.cov" --exclude="*" $PKGDIR/ /mnt/ |
There was a problem hiding this comment.
I believe this is not needed since $PKGDIR and /mnt are the same directory.
tpapp
reviewed
Nov 8, 2018
|
@frekrikekre: update the Docker image, and restarted the build. Perhaps the workaround can be removed now? Otherwise, LGTM, thanks for doing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.