Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"exporting" save #69

Closed
tpapp opened this issue Feb 23, 2018 · 3 comments
Closed

"exporting" save #69

tpapp opened this issue Feb 23, 2018 · 3 comments

Comments

@tpapp
Copy link
Collaborator

tpapp commented Feb 23, 2018

In the spirit of #62, it would be nice if PGFPlotsX.save would just work with less typing (or workarounds, like const something = ...). It is of course too generic to export as is. I was thinking of two alternatives:

  1. rename it, eg pgfsave,

  2. integrate it into a general mechanism like FileIO.jl

@KristofferC
Copy link
Owner

FileIO is not something I want as a dependency, see e.g.: JuliaPlots/Plots.jl#1379. Exporting pgfsave makes sense to me.

@tpapp
Copy link
Collaborator Author

tpapp commented Feb 23, 2018

I agree. Should we keep save (aliased to pgfsave, which is exported), or rename it? Renaming would be cleaner.

@KristofferC
Copy link
Owner

I don't think it is any harm keeping a non-exported save. It could be an alias to pgfsave or vice versa. If only, just to not bother people with unnecessary deprecation warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants