Finalize skale #387
Merged
Finalize skale #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zapaz
commented
Apr 30, 2024
common/package.json
Outdated
| @@ -32,6 +33,7 @@ | |||
| "@types/node": "^20.12.7", | |||
| "findup-sync": "^5.0.0", | |||
| "tslib": "^2.6.2", | |||
| "typescript": "^5.4.5" | |||
| "typescript": "^5.4.5", | |||
| "viem": "^2.9.16" | |||
There was a problem hiding this comment.
should not add viem already
common/src/common/provider-get.ts
Outdated
| @@ -8,6 +8,8 @@ import type { WindowExternalProvider } from "./types"; | |||
| import { getChecksumAddress, sleep } from "../common/config"; | |||
| import { ethers } from "ethers"; | |||
| import { networks } from "./networks"; | |||
| import { receiveFunds } from "@kredeum/skale"; | |||
| import { Address } from "viem"; | |||
| const signer = provider.getSigner(accountOrIndex); | ||
| const signerAddress = (await signer.getAddress()) as Address; | ||
|
|
||
| await receiveFunds(signerAddress, chainId); |
There was a problem hiding this comment.
allow string in receiveFunds
| const signer = provider.getSigner(accountOrIndex); | ||
| const signerAddress = (await signer.getAddress()) as Address; | ||
|
|
||
| await receiveFunds(signerAddress, chainId); |
There was a problem hiding this comment.
check before chainId need this ("paymaster" attribute in networks.json)
if hasPaymaster(chainId) {...}
contracts/addresses.json
Outdated
| @@ -282,6 +287,7 @@ | |||
| "OpenNFTsFactoryV3": "0xb5c8CB0846317d82af2DbF90713716B01A2f680a", | |||
| "OpenNFTsResolver": "0x25F56b5527F5634752Fd2C85564E8d2484cAAEF3", | |||
| "OpenNFTsV4": "0xd1ca741de2d2975822ADf4646Cf0A8AE3Df51c78", | |||
| "OpenNFTsV4Skale_last": "0xaBC576652433154Ab5F9cF1A2F4f0457d7690cc6", | |||
gulp/package.json
Outdated
| @@ -30,4 +30,4 @@ | |||
| "sass": "^1.75.0" | |||
| }, | |||
| "type": "module" | |||
| } | |||
gulp/src/scss/_networks.scss
Outdated
| @@ -1,2 +1 @@ | |||
| $networks: "mainnet", "arbitrum", "optimism", "base", "linea", "mantle", "blast", "polygon-zkevm", "mode", "manta-pacific", "polygon", "gnosis", "avalanche", "fantom", "bsc", "scroll", "zora", "celo", "telos", "taiko", | |||
| "skale", "local"; | |||
| $networks: "mainnet", "arbitrum", "optimism", "base", "linea", "mantle", "blast", "polygon-zkevm", "mode", "manta-pacific", "polygon", "gnosis", "avalanche", "fantom", "bsc", "scroll", "zora", "celo", "telos", "taiko", "skale", "skale-calypso", "local"; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skale specific developments