Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rom] Unify analysis stage #9439

Merged
merged 16 commits into from
Dec 15, 2021
Merged

[Rom] Unify analysis stage #9439

merged 16 commits into from
Dec 15, 2021

Conversation

rubenzorrilla
Copy link
Member

📝 Description
This PR unifies the ROM analysis stage classes to a unique RomAnalysis one. The tests have been updated accordingly. The mechanism I propose relies on #9341 (also see here). In a nutshell, we retrieve the parent analysis stage from the new json analysis_stage entry to create a derived instance of it through CreateRomAnalysisInstance factory method. Note that this is extended in CreateHRomAnalysisInstance for the hyper-reduction.

@Rbravo555 @SADPR I'd like to hear your opinion about the following points (most probably to be amended in future PRs):

  1. Do you think it is possible to add an extra hyper_reduction : true field to the rom_settings in the RomParameters.json? This would make possible to get rid of the CreateHRomAnalysisInstance factory as well as the HRomAnalysis class extension.
  2. I don't love passing the element selector as a string to the RomAnalysis constructor. However, all the alternatives that come to my mind imply modifying the original ProjectParameters.json, something that, as far as I understand, we want to avoid. Having said this, we may need to live with this.
  3. I didn't update the examples repository yet. After going through these, I think we should first create some auxiliary routines, mainly for the basis calculation and storage. Right now the scripts in there are way too customized.

@rubenzorrilla rubenzorrilla added Enhancement Cleanup Applications After Release Refactor When code is moved or rewrote keeping the same behavior ROM labels Dec 10, 2021
@rubenzorrilla rubenzorrilla self-assigned this Dec 10, 2021
SADPR
SADPR previously approved these changes Dec 15, 2021
Copy link
Contributor

@SADPR SADPR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Rbravo555
Rbravo555 previously approved these changes Dec 15, 2021
@Rbravo555 Rbravo555 dismissed stale reviews from SADPR and themself via 82c4611 December 15, 2021 10:21
@Rbravo555
Copy link
Member

LGTM!

@rubenzorrilla rubenzorrilla merged commit 4062546 into master Dec 15, 2021
@rubenzorrilla rubenzorrilla deleted the rom/unify-analysis-stage branch December 15, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
After Release Applications Cleanup Enhancement Refactor When code is moved or rewrote keeping the same behavior ROM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants