-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rom] Unify analysis stage #9439
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SADPR
previously approved these changes
Dec 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Rbravo555
previously approved these changes
Dec 15, 2021
LGTM! |
Rbravo555
approved these changes
Dec 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
After Release
Applications
Cleanup
Enhancement
Refactor
When code is moved or rewrote keeping the same behavior
ROM
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR unifies the ROM analysis stage classes to a unique
RomAnalysis
one. The tests have been updated accordingly. The mechanism I propose relies on #9341 (also see here). In a nutshell, we retrieve the parent analysis stage from the new jsonanalysis_stage
entry to create a derived instance of it throughCreateRomAnalysisInstance
factory method. Note that this is extended inCreateHRomAnalysisInstance
for the hyper-reduction.@Rbravo555 @SADPR I'd like to hear your opinion about the following points (most probably to be amended in future PRs):
hyper_reduction : true
field to therom_settings
in theRomParameters.json
? This would make possible to get rid of theCreateHRomAnalysisInstance
factory as well as theHRomAnalysis
class extension.RomAnalysis
constructor. However, all the alternatives that come to my mind imply modifying the originalProjectParameters.json
, something that, as far as I understand, we want to avoid. Having said this, we may need to live with this.