[GeoMechanicsApplication] Split ApplyComponentTableProcess in header and source #13122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and moved as many includes as possible to the source
avdg81
reviewed
Feb 12, 2025
|
|
||
| #include "includes/kratos_export_api.h" | ||
| #include "includes/kratos_parameters.h" | ||
| #include "includes/model_part.h" |
There was a problem hiding this comment.
I believe we can move this #include to the .cpp file now, since the interface uses references to ModelParts only. In other words, a forward declaration will do here.
There was a problem hiding this comment.
I thought so to, tried, but get (very vague) compiler errors, let's have a look together at this
There was a problem hiding this comment.
Managed to find why, I added a missing include in a different file to be able to get the forward declare to work
|
|
||
| using TableType = Table<double, double>; | ||
|
|
||
| ApplyComponentTableProcess(ModelPart& model_part, Parameters rParameters); |
There was a problem hiding this comment.
Let's make the parameter names comply with the Kratos Style Guide:
Suggested change
| ApplyComponentTableProcess(ModelPart& model_part, Parameters rParameters); | |
| ApplyComponentTableProcess(ModelPart& rModelPart, Parameters ProcessSettings); |
avdg81
approved these changes
Feb 13, 2025
rfaasse
deleted the
geo/split-apply-component-table-process-in-header-source
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
There was no reason to have a single .hpp file (no templated functions) for this process, so it was split into a header + source. No functional changes were done, just:
Infofunction