[GeoMechanicsApplication] Free dof for geo table process #13112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfaasse
requested review from
avdg81 and
markelov208
and removed request for
avdg81
markelov208
previously approved these changes
Feb 11, 2025
Comment on lines
73
to
78
| r_model_part.GetProcessInfo()[TIME] = 0.5; | ||
| process.ExecuteInitializeSolutionStep(); | ||
| expected_value = 1.0; | ||
| expected_fixity = true; | ||
| AssertNodesHaveCorrectValueAndFixity(expected_value, expected_fixity, r_model_part); | ||
|
|
There was a problem hiding this comment.
Is this to test the table itself?
There was a problem hiding this comment.
Yes, since there was no coverage for that part yet, I added this extra step, to just double check if this works correctly. I agree it's not really part of this test, so I'll move it to a new UT.
avdg81
reviewed
Feb 12, 2025
...sApplication/tests/cpp_tests/custom_processes/test_apply_scalar_constraint_table_process.cpp
Outdated
Show resolved
Hide resolved
...sApplication/tests/cpp_tests/custom_processes/test_apply_scalar_constraint_table_process.cpp
Outdated
Show resolved
Hide resolved
...sApplication/tests/cpp_tests/custom_processes/test_apply_scalar_constraint_table_process.cpp
Show resolved
Hide resolved
...sApplication/tests/cpp_tests/custom_processes/test_apply_scalar_constraint_table_process.cpp
Outdated
Show resolved
Hide resolved
avdg81
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR makes sure that DoF are freed in the execute finalize of the table process