[ThermalDEM] Heat generation features #13003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlejandroCornejo
previously approved these changes
Jan 13, 2025
| // Main authors: Rafael Rangel ([email protected]) | ||
| // | ||
|
|
||
| #if !defined(REAL_CONTACT_MODEL_RANGEL_AREA_H_INCLUDED) |
There was a problem hiding this comment.
Now we use:
#pragma once
and remove the lower part related to it
| const double eff_radius = ComputeEffectiveRadius(); | ||
| const double eff_mass = ComputeEffectiveMass(); | ||
| const double eff_young = ComputeEffectiveYoungReal(); | ||
| const double impact_normal_velocity = fabs(GetContactParameters().impact_velocity[0]); |
There was a problem hiding this comment.
Suggested change
| const double impact_normal_velocity = fabs(GetContactParameters().impact_velocity[0]); | |
| const double impact_normal_velocity = std::abs(GetContactParameters().impact_velocity[0]); |
AlejandroCornejo
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some features from local implementations made for recent investigations on heat generation by energy dissipation.
It mainly includes new heat generation mechanisms that were studied and new graphs.