[Core] Fix Clang warning when discard-qualifier on line 133 of registry.h

[loumalouomega]

📝 Description

Fix Clang warning when discard-qualifier on line 133 of registry.h. const is not needed for the cend iterator.

🆕 Changelog

• Fix Clang warning when discard-qualifier on line 133 of registry.h

[roigcarlo]

i would expect to be the oposite, cend and cbegin should requeire const. If not static auto const cend() at least should be static auto cend() const

[loumalouomega]

i would expect to be the oposite, cend and cbegin should requeire const. If not static auto const cend() at least should be static auto cend() const

I just do as the compiler says

[roigcarlo]

I mean yes, the solution you did solves the problem, but we end up having the same function twice. end and cend should be different somewhere.

[loumalouomega]

I mean yes, the solution you did solves the problem, but we end up having the same function twice. end and cend should be different somewhere.

No, cend returns a const interator instead of a iterator. The auto hides that.

[roigcarlo]

omg are we using auto for return types now? God have mercy

[loumalouomega]

I mean yes, the solution you did solves the problem, but we end up having the same function twice. end and cend should be different somewhere.

No, cend returns a const interator instead of a iterator. The auto hides that.

kratos/includes/registry.h:133:17: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers]
    static auto const cend()

[loumalouomega]

omg are we using auto for return types now? God have mercy

Not my code

[roigcarlo]

Na its fine, I hadn't seen the auto, sorry for the noise :P

[loumalouomega]

Na its fine, I hadn't seen the auto, sorry for the noise :P