[CLApp] Generalizing the Serial Parallel Rule of Mixtures to perform 2d simulations #12983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Vicente Mataix Ferrandiz | ||
| // Fernando Rastellini | ||
| // Collaborator: Lucia Barbu | ||
| // Vicente Mataix |
There was a problem hiding this comment.
Besides, she's a good woman, I'll put her back
| return Kratos::make_shared<SerialParallelRuleOfMixturesLaw>(fiber_volumetric_participation, parallel_directions); | ||
|
|
||
| Vector parallel_directions = NewParameters["parallel_behaviour_directions"].GetVector(); | ||
| KRATOS_ERROR_IF_NOT(parallel_directions.size() == VoigtSize) << "The parallel_behaviour_directions vector is not consistent with the VoigtSize of the Serial Parallel Rule of Mixtures CL..." << std::endl; |
There was a problem hiding this comment.
Suggested change
| KRATOS_ERROR_IF_NOT(parallel_directions.size() == VoigtSize) << "The parallel_behaviour_directions vector is not consistent with the VoigtSize of the Serial Parallel Rule of Mixtures CL..." << std::endl; | |
| KRATOS_ERROR_IF_NOT(parallel_directions.size() == VoigtSize) << "The parallel_behaviour_directions vector is not consistent with the VoigtSize of the Serial Parallel Rule of Mixtures CL. parallel_directions.size(): " << parallel_directions.size() << " vs VoigtSize: " << VoigtSize << std::endl; |
Specify sizes
| const std::size_t voigt_size = this->GetStrainSize(); | ||
| const int num_parallel_components = inner_prod(mParallelDirections, mParallelDirections); | ||
| const int num_serial_components = voigt_size - num_parallel_components; | ||
| const SizeType voigt_size = GetStrainSize(); |
There was a problem hiding this comment.
Question. Do we do not assume the Voigt size from the Dimension size?, sorry I forgot that detail
There was a problem hiding this comment.
yes, the GetStrainSize() return a static SizeType, I can remove it if you think is best to access it directly.
There was a problem hiding this comment.
I those method were override somewhere else it could make some sense, but here I thinbk it is better to just use it.
| noalias(B_tensor) = prod(F, trans(F)); | ||
|
|
||
| AdvancedConstitutiveLawUtilities<6>::CalculateAlmansiStrain(B_tensor, r_strain_vector); | ||
| AdvancedConstitutiveLawUtilities<VoigtSize>::CalculateAlmansiStrain(B_tensor, r_strain_vector); |
There was a problem hiding this comment.
But in here VoigtSize is retrieved as static
| if (rValue.size1() != voigt_size) | ||
| rValue.resize(voigt_size, voigt_size, false); | ||
| noalias(rValue) = MathUtils<double>::StrainVectorToTensor(matrix_strain_vector); | ||
| return rValue; | ||
| } else if (rThisVariable == GREEN_LAGRANGE_STRAIN_TENSOR_FIBER) { | ||
| const std::size_t voigt_size = this->GetStrainSize(); | ||
| const std::size_t voigt_size = GetStrainSize(); |
There was a problem hiding this comment.
The same for the every GetStrainSize
Comment on lines
1689
to
1692
| KRATOS_ERROR_IF(VoigtSize != mpMatrixConstitutiveLaw->GetStrainSize()) << "The Strain size of the mpMatrixConstitutiveLaw is not consistent with the Srial Parallel Rule of Mixtures..." << std::endl; | ||
| KRATOS_ERROR_IF(VoigtSize != mpFiberConstitutiveLaw->GetStrainSize()) << "The Strain size of the mpFiberConstitutiveLaw is not consistent with the Srial Parallel Rule of Mixtures..." << std::endl; | ||
| KRATOS_ERROR_IF(mpMatrixConstitutiveLaw->WorkingSpaceDimension() != mpFiberConstitutiveLaw->WorkingSpaceDimension()) << "The WorkingSpaceDimension of the fiber and matrix mismatch..." << std::endl; | ||
| KRATOS_ERROR_IF(mpMatrixConstitutiveLaw->GetStrainSize() != mpFiberConstitutiveLaw->GetStrainSize()) << "The GetStrainSize of the fiber and matrix mismatch..." << std::endl; |
There was a problem hiding this comment.
As in the other example, Add the sizes in the error message
| @@ -47,10 +47,13 @@ namespace Kratos | |||
| /** | |||
| * @class SerialParallelRuleOfMixturesLaw | |||
| * @ingroup StructuralMechanicsApplication | |||
| * @brief This CL implements the serial-parallel rule of mixtures developed by F.Rastellini | |||
| * @brief This CL implements the serial-parallel rule of mixtures detailed in Cornejo et al. "Methodology for the analysis of post-tensioned structures using a constitutive serial-parallel rule of mixtures" | |||
| }; | ||
|
|
||
| /** | ||
| * @brief Voigt tensor size: | ||
| */ | ||
| SizeType GetStrainSize() const override | ||
| { | ||
| return 6; | ||
| return VoigtSize; |
There was a problem hiding this comment.
I would keep the methods of course, but in code use directly the static sizes.
loumalouomega
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
In this PR I am:
SerialParallelRuleOfMixturesLawto be used in 3d and in 2d simulations. The implementation is generic thanks to the newly templatedDimension. A few checks have been added to avoid incompatibilities between 2D and 3D individual constitutive laws.AdvancedConstitutiveLawsUtilitieshave been enhanced with aCalculateTangentTensorByPerturbationmethod to start avoiding repetition in other CLs in the future.