[GeoMechanicsApplication] Create exit criterion for c phi process #12980
Conversation
| } | ||
|
|
||
| // After halving the initial reduction increment (0.1) for the seventh time, it becomes | ||
| // 0,00078125, so it should throw an exception |
There was a problem hiding this comment.
Nitpicking (use the dot as decimal separator):
| // 0,00078125, so it should throw an exception | |
| // 0.00078125, so it should throw an exception |
| // 0,00078125, so it should throw an exception | ||
| KRATOS_EXPECT_EXCEPTION_IS_THROWN( | ||
| process.ExecuteInitializeSolutionStep(), | ||
| "Reduction increment should not drop below 0.001, calculation stopped. Final safety factor = 1"); |
There was a problem hiding this comment.
I was a bit surprised to see a final safety factor of 1.0. I'm not sure whether I would have expected that particular value. Can you perhaps help me to see why 1.0 must be the correct value in this case?
There was a problem hiding this comment.
Indeed. the error message use mPreviousReductionFactor which is only updated in ExecuteFinalizeSolutionStep.
process.ExecuteFinalizeSolutionStep is not invoked in the test, hence the factor of safety remained 1.
There was a problem hiding this comment.
You're right, I left it out to keep the test simpler, but now it isn't really testing the reporting of the final safety factor. Changed the test
…er review comments
| // 0,00078125, so it should throw an exception | ||
| KRATOS_EXPECT_EXCEPTION_IS_THROWN( | ||
| process.ExecuteInitializeSolutionStep(), | ||
| "Reduction increment should not drop below 0.001, calculation stopped. Final safety factor = 1"); |
There was a problem hiding this comment.
You're right, I left it out to keep the test simpler, but now it isn't really testing the reporting of the final safety factor. Changed the test
📝 Description
There was no exit criterium for c-phi for a small reduction increment (i.e. very small changes to c and phi). This PR adds it