[GeoMechanicsApplication] Create exit criterion for c phi process #12980
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avdg81
reviewed
Jan 7, 2025
| } | ||
|
|
||
| // After halving the initial reduction increment (0.1) for the seventh time, it becomes | ||
| // 0,00078125, so it should throw an exception |
There was a problem hiding this comment.
Nitpicking (use the dot as decimal separator):
Suggested change
| // 0,00078125, so it should throw an exception | |
| // 0.00078125, so it should throw an exception |
| // 0,00078125, so it should throw an exception | ||
| KRATOS_EXPECT_EXCEPTION_IS_THROWN( | ||
| process.ExecuteInitializeSolutionStep(), | ||
| "Reduction increment should not drop below 0.001, calculation stopped. Final safety factor = 1"); |
There was a problem hiding this comment.
I was a bit surprised to see a final safety factor of 1.0. I'm not sure whether I would have expected that particular value. Can you perhaps help me to see why 1.0 must be the correct value in this case?
There was a problem hiding this comment.
Indeed. the error message use mPreviousReductionFactor which is only updated in ExecuteFinalizeSolutionStep.
process.ExecuteFinalizeSolutionStep is not invoked in the test, hence the factor of safety remained 1.
WPK4FEM
reviewed
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
There was no exit criterium for c-phi for a small reduction increment (i.e. very small changes to c and phi). This PR adds it