[Fluid] Low Mach Navier-Stokes formulation #12955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w-mach-navier-stokes
…w-mach-navier-stokes
…w-mach-navier-stokes
| // ConditionDataStruct data; | ||
|
|
||
| // // Allocate memory needed | ||
| // array_1d<double,MatrixSize> rhs_gauss; |
There was a problem hiding this comment.
this part is necessary?
There was a problem hiding this comment.
It is. I prefer it to leave it there for the eventual extension to unfitted mesh discretizations.
|
|
||
| // // Struct to pass around the data | ||
| // ConditionDataStruct data; | ||
| // // Allocate memory needed |
There was a problem hiding this comment.
This is a boilerplate for the future implementation of the Neumann BCs.
|
|
||
| double DynamicTau; // Dynamic tau considered in ASGS stabilization coefficients | ||
|
|
||
| double bdf0; |
There was a problem hiding this comment.
are these member vars meant to be public?
There was a problem hiding this comment.
Yes. Otherwise they wouldn't be accessible from the corresponding elements.
|
@sunethwarna @Igarizza |
Now it works 🤷♂️ |
AlejandroCornejo
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR adds a low Mach approximation Navier-Stokes formulation (at this point a very first working implementation with room for improvement).