Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core][CI][Win] Adding verbosity to detect oot #12528

Closed
wants to merge 77 commits into from
Closed

[Core][CI][Win] Adding verbosity to detect oot #12528

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
c28a629
Adding verbosity to detect oot
roigcarlo Jul 11, 2024
7de27ba
Block
loumalouomega Jul 11, 2024
5aa1e7f
Defaulting variables
roigcarlo Jul 12, 2024
69867fe
Marking tests as not working in win
roigcarlo Jul 12, 2024
e5cbf34
Merge branch 'ci/fix-out-of-time' of github.com:KratosMultiphysics/Kr…
roigcarlo Jul 12, 2024
0c90438
Disabled last test
roigcarlo Jul 12, 2024
ac2ad8d
Disabled last test
roigcarlo Jul 12, 2024
1707a4d
Trying to disable more tests in win
roigcarlo Jul 12, 2024
2fc1126
Trigger Build
roigcarlo Jul 31, 2024
f566406
Merge branch 'master' into ci/fix-out-of-time
roigcarlo Aug 19, 2024
d2dac3e
Merge branch 'ci/fix-out-of-time' of github.com:KratosMultiphysics/Kr…
roigcarlo Aug 19, 2024
d1459d6
Disabling tests until it works
roigcarlo Aug 19, 2024
d2da5c6
Disabling tests until it works
roigcarlo Aug 19, 2024
815b104
Disabling tests until it works
roigcarlo Aug 19, 2024
1f31ea8
Disabling matrix
roigcarlo Aug 19, 2024
06f7976
commenting tests
roigcarlo Aug 19, 2024
302d4ae
Disabling Rom orchestrator test
roigcarlo Aug 20, 2024
6473df9
Merge branch 'master' of https://github.com/KratosMultiphysics/Kratos…
roigcarlo Aug 20, 2024
20fdb6f
Merge branch 'ci/fix-out-of-time' of https://github.com/KratosMultiph…
roigcarlo Aug 20, 2024
a1c975e
Trying matrix tests with p310
roigcarlo Aug 21, 2024
c8368fc
Trying to disable lecture and body of the test
roigcarlo Aug 21, 2024
2455de4
Re eneable lecture
roigcarlo Aug 21, 2024
8259d91
Trying 2022 image?
roigcarlo Aug 22, 2024
a8fdf0a
Trying 2022 image 2
roigcarlo Aug 22, 2024
82148c6
Trying 2022 image 3
roigcarlo Aug 22, 2024
ed269d9
Trying 2022 image 4
roigcarlo Aug 22, 2024
9a0dd39
Merge branch 'ci/fix-out-of-time' of https://github.com/KratosMultiph…
roigcarlo Aug 23, 2024
ff274fa
Try wheelbuilder container
roigcarlo Aug 23, 2024
07d2186
reverting to regular containers and testing boost 1.80
roigcarlo Aug 23, 2024
8973fb6
Fixing almost equal taking places instead of tolerance
roigcarlo Aug 23, 2024
84339ea
Try to avoid inlining in the matrix read function
roigcarlo Aug 27, 2024
8b0ea7d
Merge branch 'ci/fix-out-of-time' of github.com:KratosMultiphysics/Kr…
roigcarlo Aug 27, 2024
e9e2f18
Revert inline, trying to allocate space for the reference matrix + de…
roigcarlo Aug 27, 2024
fa1fe28
I regret nothing
roigcarlo Aug 28, 2024
eb2b043
Temporaly disabling most pipelines and truncating windows
roigcarlo Sep 2, 2024
87115b7
Temporaly disabling most tests
roigcarlo Sep 2, 2024
ce67b4a
Disable c++ testing and pch
roigcarlo Sep 2, 2024
1846eb8
indent
roigcarlo Sep 2, 2024
60003b5
removing comments
roigcarlo Sep 2, 2024
62547c6
removing deps
roigcarlo Sep 2, 2024
656fb69
removing deps 2
roigcarlo Sep 2, 2024
2a29189
do not run cpp tests
roigcarlo Sep 2, 2024
0360c43
Merge branch 'master' into ci/fix-out-of-time
roigcarlo Oct 3, 2024
1cd8145
Try with system zlib?
roigcarlo Oct 4, 2024
f0546c9
Try to disable defender
roigcarlo Oct 7, 2024
c3d25a8
Typo
roigcarlo Oct 7, 2024
16460f2
Use cmd for test run
roigcarlo Oct 7, 2024
d707211
Trying to short names again
roigcarlo Oct 9, 2024
77bad9e
Try to print matrix to check
roigcarlo Oct 9, 2024
eb0d53f
You will bend to my will, machine
roigcarlo Oct 9, 2024
ad4e342
Test
roigcarlo Oct 10, 2024
b0348da
Merge branch 'ci/fix-out-of-time' of github.com:KratosMultiphysics/Kr…
roigcarlo Oct 10, 2024
f117440
Fixing test test
roigcarlo Oct 10, 2024
e87ee84
More debug
roigcarlo Oct 17, 2024
f68f6ce
Merge branch 'master' into ci/fix-out-of-time
roigcarlo Oct 17, 2024
6500219
Try to access files directly without python
roigcarlo Oct 17, 2024
fb69e6c
Try to access files directly without python
roigcarlo Oct 17, 2024
c0ba4b7
Remove nightly to save resources
roigcarlo Oct 17, 2024
e622832
Try to fix command
roigcarlo Oct 17, 2024
054bb03
Try hinting utf encoding in fopen
roigcarlo Oct 17, 2024
8af1c95
Reverting and using /GS-
roigcarlo Oct 17, 2024
10d8e3b
Only read from c++
roigcarlo Oct 17, 2024
c723d98
Testing hand made matrix
roigcarlo Oct 23, 2024
aefc4fc
Merge branch 'master' into ci/fix-out-of-time
roigcarlo Oct 23, 2024
2bb2364
More prints and more debug info
roigcarlo Oct 23, 2024
0889e2e
Merge branch 'master' into ci/fix-out-of-time
roigcarlo Oct 23, 2024
173fabf
Harcode everything
roigcarlo Oct 23, 2024
f1b4a7f
Merge branch 'ci/fix-out-of-time' of github.com:KratosMultiphysics/Kr…
roigcarlo Oct 23, 2024
c6c5e7c
Adding simple function
roigcarlo Oct 23, 2024
850980d
Warning and split file
roigcarlo Oct 23, 2024
ddd213e
Warning
roigcarlo Oct 23, 2024
ad7db94
Export API
roigcarlo Oct 23, 2024
a6de753
Remove test function
roigcarlo Oct 23, 2024
8ba62b9
Restore minimal functionality
roigcarlo Oct 23, 2024
2b54553
Remove inlining
roigcarlo Oct 23, 2024
c7dcf95
removing PESKY LITTLE F***** of const
roigcarlo Oct 23, 2024
59afa51
Missing windows export/imports
roigcarlo Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: '3.8'
python-version: '3.10'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

BTW 3.13 will be released in like 6 weeks ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then its time to move to 3.12 :D. Sadly seems that moving to 3.10 does not help :S

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roigcarlo can you give me a quick rundown on what's going on? I know this oot issue has been around for quite a while, but not much else. Why would changing the python exec help?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically some python tests fail in windows since July. It began for no apparent reason. I tracked down that there were some updates to the Windows container but that's it. To my knowledge all tests failing involve reading (or maybe just using) csr matrices at some point.

After much testing I suspect that the error happens while calling the mm_read_banner from the matrixmarket lib (mmio.h and mmio.c).

The problem is that in 3 months I have been unable to reproduce this anywhere, and the windows container used to run in the CI is not public because of licences issues.


- name: CI configuration
shell: bash
Expand Down Expand Up @@ -467,7 +467,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: '3.8'
python-version: '3.10'

- name: CI configuration
shell: bash
Expand Down
8 changes: 4 additions & 4 deletions kratos/tests/test_KratosCore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
# import test_mortar_mapper
import test_normal_utils
import test_skin_detection_process
# import test_sparse_matrix_multiplication
import test_sparse_matrix_multiplication
import test_variable_component
import test_variable_redistribution
import test_object_printing
Expand Down Expand Up @@ -155,9 +155,9 @@ def AssembleTestSuites():
smallSuite.addTests(KratosUnittest.TestLoader().loadTestsFromTestCases([test_normal_utils.TestNormalUtilsCoarseSphere]))
smallSuite.addTests(KratosUnittest.TestLoader().loadTestsFromTestCases([test_normal_utils.TestNormalUtilsQuadSphere]))
smallSuite.addTests(KratosUnittest.TestLoader().loadTestsFromTestCases([test_normal_utils.TestNormalUtils2DSymmetricalSquare]))
# smallSuite.addTests(KratosUnittest.TestLoader().loadTestsFromTestCases([test_sparse_matrix_multiplication.TestSparseMatrixSum]))
# smallSuite.addTests(KratosUnittest.TestLoader().loadTestsFromTestCases([test_sparse_matrix_multiplication.TestSparseMatrixTranspose]))
# smallSuite.addTests(KratosUnittest.TestLoader().loadTestsFromTestCases([test_sparse_matrix_multiplication.TestSparseMatrixMultiplication]))
smallSuite.addTests(KratosUnittest.TestLoader().loadTestsFromTestCases([test_sparse_matrix_multiplication.TestSparseMatrixSum]))
smallSuite.addTests(KratosUnittest.TestLoader().loadTestsFromTestCases([test_sparse_matrix_multiplication.TestSparseMatrixTranspose]))
smallSuite.addTests(KratosUnittest.TestLoader().loadTestsFromTestCases([test_sparse_matrix_multiplication.TestSparseMatrixMultiplication]))
smallSuite.addTests(KratosUnittest.TestLoader().loadTestsFromTestCases([test_variable_component.TestVariableComponent]))
smallSuite.addTests(KratosUnittest.TestLoader().loadTestsFromTestCases([test_variable_redistribution.TestVariableRedistributionUtility]))
smallSuite.addTests(KratosUnittest.TestLoader().loadTestsFromTestCases([test_object_printing.TestObjectPrinting]))
Expand Down
Loading