Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OptApp] Fix connectivity preserve modelpart controller #12406

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

sunethwarna
Copy link
Member

@sunethwarna sunethwarna commented May 25, 2024

📝 Description
This fixes the ConncetivityPreservingModelPartController in OptApp to be used with multiple element types and multiple condition types.

Requires #12405 .

🆕 Changelog

  • Fixes ConncetivityPreservingModelPartController

@sunethwarna sunethwarna added Applications Python FastPR This Pr is simple and / or has been already tested and the revision should be fast Optimization related to OptApp labels May 25, 2024
@sunethwarna sunethwarna self-assigned this May 25, 2024
Igarizza
Igarizza previously approved these changes May 30, 2024
@sunethwarna sunethwarna enabled auto-merge June 10, 2024 08:38
Copy link
Member

@Igarizza Igarizza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunethwarna Haven't you merged smth very similar already?

@sunethwarna sunethwarna merged commit b6ad945 into master Jun 10, 2024
11 checks passed
@sunethwarna sunethwarna deleted the optapp/conn_preserv_model_part/fix branch June 10, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Applications FastPR This Pr is simple and / or has been already tested and the revision should be fast Optimization related to OptApp Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants