Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Removed a redundant override #12384

Merged
merged 1 commit into from
May 16, 2024

Conversation

avdg81
Copy link
Contributor

@avdg81 avdg81 commented May 15, 2024

📝 Description
Removed an overridden function that simply forwarded the request to its base class. Since that is the default behavior when no override is provided, it's better to remove the redundant implementation.

Removed an overridden function that simply forwarded the request to its
base class. Since that is the default behavior when no `override` is
provided, it's better to remove the redundant implementation.
@avdg81 avdg81 added Cleanup GeoMechanics Issues related to the GeoMechanicsApplication labels May 15, 2024
@avdg81 avdg81 requested a review from rfaasse May 15, 2024 15:27
@avdg81 avdg81 self-assigned this May 15, 2024
Copy link
Contributor

@rfaasse rfaasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing this redundant code!

@avdg81 avdg81 merged commit 407368d into master May 16, 2024
11 checks passed
@avdg81 avdg81 deleted the geo/remove-redundant-override branch May 16, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup GeoMechanics Issues related to the GeoMechanicsApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants