Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Add point flux (source) condition for Pw #12376

Merged
merged 14 commits into from
May 15, 2024

Conversation

mnabideltares
Copy link
Contributor

📝 Description
As part of our ongoing development efforts, we need to implement a water flux boundary condition for our 1D pressure line element in order to accurately simulate fluid flow behavior. Currently, the boundary conditions for this element type are limited to Dirichlet, and the inclusion of a water flux boundary condition is crucial for modeling scenarios where water flow play a significant role. This `boundary is also crucial for wel element which will be implemented in the near future.

🆕 Changelog

  • Added point flux condition for Pw
  • Added test cases
  • Added documentation

Copy link
Contributor

@markelov208 markelov208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Mohamed, a very good work. Just a few comments.

@mnabideltares mnabideltares requested a review from markelov208 May 13, 2024 21:53
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In geo technics it is common to have the depth coordinate on the vertical axis in the graph. ( which leads to water pressure on the horizontal axis here. )

@mnabideltares mnabideltares requested a review from WPK4FEM May 14, 2024 09:12
Copy link
Contributor

@markelov208 markelov208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mohamed, from my view-point, it is good to merge.

@mnabideltares mnabideltares merged commit 085a2af into master May 15, 2024
11 checks passed
@mnabideltares mnabideltares deleted the geo/12325-add-point-pw-flux branch May 15, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

[GeoMechanicsApplication] Add point flux (source) condition for Pw
3 participants