-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GeoMechanicsApplication] Add point flux (source) condition for Pw #12376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Mohamed, a very good work. Just a few comments.
applications/GeoMechanicsApplication/tests/test_pressure_point_flux/README.md
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_conditions/Pw_point_flux_condition.cpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_conditions/Pw_point_flux_condition.hpp
Outdated
Show resolved
Hide resolved
… error because of missing #include check.h)
Gave compiliation errors under Linux
applications/GeoMechanicsApplication/custom_conditions/Pw_point_flux_condition.cpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_conditions/Pw_point_flux_condition.hpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/test_pressure_point_flux.py
Outdated
Show resolved
Hide resolved
...ions/GeoMechanicsApplication/tests/test_pressure_point_flux/Common/MaterialParameters2D.json
Show resolved
Hide resolved
...ions/GeoMechanicsApplication/tests/test_pressure_point_flux/Common/MaterialParameters2D.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In geo technics it is common to have the depth coordinate on the vertical axis in the graph. ( which leads to water pressure on the horizontal axis here. )
...ts/test_pressure_point_flux/test_pressure_point_flux_line_element3D3N/ProjectParameters.json
Outdated
Show resolved
Hide resolved
.../tests/test_pressure_point_flux/documentation_data/test_pressure_point_flux_line_element.svg
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mohamed, from my view-point, it is good to merge.
📝 Description
As part of our ongoing development efforts, we need to implement a water flux boundary condition for our 1D pressure line element in order to accurately simulate fluid flow behavior. Currently, the boundary conditions for this element type are limited to Dirichlet, and the inclusion of a water flux boundary condition is crucial for modeling scenarios where water flow play a significant role. This `boundary is also crucial for wel element which will be implemented in the near future.
🆕 Changelog