Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GeoMechanicsApplication] Implement well constitutive behaviour for line thermal element #12370
[GeoMechanicsApplication] Implement well constitutive behaviour for line thermal element #12370
Changes from 13 commits
ab61bc8
ec7889a
f684843
22bbea7
12a2a88
888f3af
507de31
a318f95
33eabb4
9550840
77a23f9
765bdbe
d09c3ba
6be0896
370b2a4
8a45f84
03b58e8
7f2d444
06b93a9
18493b1
f5a2a2e
9831df4
0a76620
ff656e0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add a simple test to check that the construction throws when the dimension is wrong by using
KRATOS_EXPECT_EXCEPTION_IS_THROWN
, see e.g.Kratos/applications/GeoMechanicsApplication/tests/cpp_tests/test_variables_utilities.cpp
Lines 26 to 31 in 1166a00
I don't consider this blocking, but it might be a nice test to add.