Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RomApp] Remove legacy solvers and analysis stages tailored for physics #12295

Merged
merged 5 commits into from
Apr 19, 2024

Conversation

Rbravo555
Copy link
Member

@Rbravo555 Rbravo555 commented Apr 19, 2024

📝 Description
In early 2022, as part of PR #9490, the RomApplication underwent significant changes with the unification of its solvers and analysis stages into a single streamlined process. This update deprecated the use of individual solvers and analysis stages, and introduced warnings when the outdated methods were called. This PR completes that transition by removing the legacy components in favor of the modern, unified workflow managed by the RomManager.

All tests in the RomApplication have been using the new system, therefore no further changes are required in this repo, however, there are some cases in the Examples repository that still use the deprecated stuff, we will have to either erase them or upgrade them as this PR will render them completely obsolete

🆕 Changelog

  • Removed five legacy solvers and three legacy analysis stages, along with the outdated python_solver_wrapper_rom.
  • Renamed new_python_solver_wrapper_rom.py to python_solver_wrapper_rom.py to reflect its standardization.
  • Updated rom_analysis.py to invoke the newly renamed python_solver_wrapper_rom.py

@Rbravo555 Rbravo555 marked this pull request as ready for review April 19, 2024 14:35
@Rbravo555 Rbravo555 requested a review from a team as a code owner April 19, 2024 14:35
Copy link
Member

@rubenzorrilla rubenzorrilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes perfect sense for me. Regarding the cases in the examples repo, I'd upgrade them to current framework.

@Rbravo555 Rbravo555 merged commit 4f36915 into master Apr 19, 2024
11 checks passed
@Rbravo555 Rbravo555 deleted the RomApp_RemoveLegacySolvers branch April 19, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants