Remove the runkratos executable
#11898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The CI script no longer defines `INSTALL_RUNKRATOS`. - Also removed the `INSTALL_RUNKRATOS` definition from the top-level `CMakeLists.txt` file. As a result, it will no longer attempt to build the `runkratos` executable. - Also removed the `INSTALL_RUNKRATOS` definition from two other configuration scripts. - Removed the description of `-DINSTALL_RUNKRATOS` from the top-level `INSTALL.md` file.
Also removed the specific `CMakeLists.txt` file that was used for building the `runkratos` executable.
Also updated some custom scripts such that they no longer attempt to execute the `runkratos` executable.
Also removed all references to `runkratos` from help texts and docstrings.
|
@roigcarlo: could you please review the changes that are proposed in this PR? @loumalouomega: are these changes in line with your suggestions for PR #11506? Many thanks in advance for your feedback. |
roigcarlo
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR extracts the changes related to the removal of
runkratosfrom PR #11506. The aim is to assist in breaking down PR #11506 into smaller pieces that can be reviewed more easily and which can be merged back separately. In essence, this PR removes the source of therunkratosexecutable as well as its build instructions. Furthermore, all scripts that used to callrunkratoshave been updated. Also the documentation has been updated, such that it no longer references therunkratosexecutable.When approved, the commits will be squashed.