-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Fix Kernel Destructor #11511
[Core] Fix Kernel Destructor #11511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
@loumalouomega I've been looking for the error of this and as I suspected is very hard to fix without revamping the test, so I am afraid this needs to be included in the GTests PR and cannot be split. The error happens because some applications ( specifically the ones that have custom custom workflows in c++ like GeoMechanics) have custom kernels. So: So in order to fix this I would have to disable all the cpp tests with cpp workflows or remade the script so instead of using the python instance that is created with I don't want to disable those tests in the meantime and I will not make the changes in the resting script because I will ditch them when making the GTests. So, if you are ok with the changes here, I will just close the PR and consider this part reviewer in the other PR. As a note, the current behavior is the wrong one as all tests are assuming that the kernel is in a correct state after a tests is executed, which is a very bold assumption and could cause interference between all the tests, |
Okay :') |
Closing. See #11506 |
📝 Description
Kratos kernel now cleans the list of applications registered and components once destroyed, preventing pointers to deleted instances of Components and no longer available applications from existing after calling the kernel initialization and application registry without unloading the shared lib.
Related #11506
🆕 Changelog