changed following the review comments

KratosMultiphysics · May 17, 2024 · f52e0c1 · f52e0c1
1 parent ff1b41a
commit f52e0c1
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_element.cpp b/applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_element.cpp
@@ -1234,7 +1234,7 @@ void UPwSmallStrainElement<TDim, TNumNodes>::CalculateAndAddStiffnessMatrix(Matr
 {
     KRATOS_TRY
 
-    Matrix stiffness_matrix = GeoEquationOfMotionUtilities::CalculateStiffnessMatrixGPoint(
+    const auto stiffness_matrix = GeoEquationOfMotionUtilities::CalculateStiffnessMatrixGPoint(
         rVariables.B, rVariables.ConstitutiveMatrix, rVariables.IntegrationCoefficient);
     GeoElementUtilities::AssembleUUBlockMatrix(rLeftHandSideMatrix, stiffness_matrix);
 
@@ -1332,7 +1332,6 @@ void UPwSmallStrainElement<TDim, TNumNodes>::CalculateAndAddStiffnessForce(Vecto
     noalias(rVariables.UVector) =
         -1.0 * prod(trans(rVariables.B), mStressVector[GPoint]) * rVariables.IntegrationCoefficient;
 
-    // Distribute stiffness block vector into elemental vector
     GeoElementUtilities::AssembleUBlockVector(rRightHandSideVector, rVariables.UVector);
 
     KRATOS_CATCH("")

diff --git a/...ications/GeoMechanicsApplication/custom_elements/small_strain_U_Pw_diff_order_element.cpp b/...ications/GeoMechanicsApplication/custom_elements/small_strain_U_Pw_diff_order_element.cpp
@@ -1717,10 +1717,9 @@ void SmallStrainUPwDiffOrderElement::CalculateAndAddStiffnessMatrix(MatrixType&
 {
     KRATOS_TRY
 
-    Matrix stiffness_matrix = GeoEquationOfMotionUtilities::CalculateStiffnessMatrixGPoint(
+    const auto stiffness_matrix = GeoEquationOfMotionUtilities::CalculateStiffnessMatrixGPoint(
         rVariables.B, rVariables.ConstitutiveMatrix, rVariables.IntegrationCoefficient);
 
-    // Distribute stiffness block matrix into the elemental matrix
     GeoElementUtilities::AssembleUUBlockMatrix(rLeftHandSideMatrix, stiffness_matrix);
 
     KRATOS_CATCH("")

diff --git a/applications/GeoMechanicsApplication/custom_utilities/README.md b/applications/GeoMechanicsApplication/custom_utilities/README.md
@@ -76,7 +76,7 @@ Where $M$ and $K$ are the mass and stiffness  matrices respectively and $\alpha_
 File equation_of_motion_utilities.h includes 
 -  CalculateMassMatrix function
 -  CalculateStiffnessMatrixGPoint provides a stiffness matrix for a specific integration point
--  CalculateStiffnessMatrix provides a stiffness matrix for all integration points
+-  CalculateStiffnessMatrix provides a stiffness matrix for an element
 -  CalculateDampingMatrix function
 -  CalculateIntegrationCoefficientsInitialConfiguration function that calculates integration coefficient for all integration points
 

diff --git a/applications/GeoMechanicsApplication/custom_utilities/equation_of_motion_utilities.h b/applications/GeoMechanicsApplication/custom_utilities/equation_of_motion_utilities.h
@@ -45,9 +45,9 @@ class GeoEquationOfMotionUtilities
                                                  const Matrix& rConstitutiveMatrix,
                                                  double        IntegrationCoefficient);
 
-    static Matrix CalculateStiffnessMatrix(const std::vector<Matrix>& b_matrices,
-                                           const std::vector<Matrix>& constitutive_matrices,
-                                           const std::vector<double>& integration_coefficients);
+    static Matrix CalculateStiffnessMatrix(const std::vector<Matrix>& rBs,
+                                           const std::vector<Matrix>& rConstitutiveMatrices,
+                                           const std::vector<double>& rIntegrationCoefficients);
 
 }; /* Class GeoTransportEquationUtilities*/
 } /* namespace Kratos.*/