Fixes based on review

KratosMultiphysics · Jan 14, 2025 · f2d2ab7 · f2d2ab7
1 parent 007bf56
commit f2d2ab7
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 28 deletions.
diff --git a/applications/GeoMechanicsApplication/custom_elements/filter_compressibility_calculator.cpp b/applications/GeoMechanicsApplication/custom_elements/filter_compressibility_calculator.cpp
@@ -17,8 +17,8 @@
 namespace Kratos
 {
 
-FilterCompressibilityCalculator::FilterCompressibilityCalculator(InputProvider rInputProvider)
-    : mInputProvider(std::move(rInputProvider))
+FilterCompressibilityCalculator::FilterCompressibilityCalculator(InputProvider AnInputProvider)
+    : mInputProvider(std::move(AnInputProvider))
 {
 }
 

diff --git a/applications/GeoMechanicsApplication/custom_elements/filter_compressibility_calculator.h b/applications/GeoMechanicsApplication/custom_elements/filter_compressibility_calculator.h
@@ -60,7 +60,7 @@ class FilterCompressibilityCalculator : public ContributionCalculator
         std::function<Vector(const Variable<double>&)> mGetNodalValues;
     };
 
-    explicit FilterCompressibilityCalculator(InputProvider rInputProvider);
+    explicit FilterCompressibilityCalculator(InputProvider AnInputProvider);
 
     Matrix                    LHSContribution() override;
     Vector                    RHSContribution() override;

diff --git a/applications/GeoMechanicsApplication/custom_elements/transient_Pw_line_element.h b/applications/GeoMechanicsApplication/custom_elements/transient_Pw_line_element.h
@@ -280,8 +280,7 @@ class KRATOS_API(GEO_MECHANICS_APPLICATION) TransientPwLineElement : public Elem
     Vector CalculateProjectedGravityAtIntegrationPoints(const Matrix& rNContainer) const
     {
         const auto number_integration_points = GetGeometry().IntegrationPointsNumber(GetIntegrationMethod());
-        GeometryType::JacobiansType J_container;
-        J_container.resize(number_integration_points, false);
+        GeometryType::JacobiansType J_container{number_integration_points};
         for (std::size_t i = 0; i < number_integration_points; ++i) {
             J_container[i].resize(GetGeometry().WorkingSpaceDimension(),
                                   GetGeometry().LocalSpaceDimension(), false);
@@ -302,7 +301,7 @@ class KRATOS_API(GEO_MECHANICS_APPLICATION) TransientPwLineElement : public Elem
             array_1d<double, TDim> tangent_vector = column(J_container[integration_point_index], 0);
             tangent_vector /= norm_2(tangent_vector);
             projected_gravity(integration_point_index) =
-                MathUtils<double>::Dot(tangent_vector, body_acceleration);
+                MathUtils<>::Dot(tangent_vector, body_acceleration);
         }
         return projected_gravity;
     }

diff --git a/applications/GeoMechanicsApplication/tests/test_pressure_line_element/README.md b/applications/GeoMechanicsApplication/tests/test_pressure_line_element/README.md
@@ -27,7 +27,10 @@ In this test case, the result at node number 3 at location $y = -2 \mathrm{[m]}$
 
 
 # Test Cases for Water Pore Pressure Line Element with Filter as Retention Law
-Two test cases are repeated with modification for retention law in the material parameters. They are test cases on elements of 2D3N and 3D3N (with slope of 45 degrees). Here, the retention law is replaced by "PressureFilterLaw". The results are then compared with analytical results.
+Two test cases are repeated with modification for retention law in the material parameters. They are test cases on elements of 2D3N and 3D3N (with slope of 45 degrees). Here, the retention law is replaced by "PressureFilterLaw". The results are then compared with analytical results. The analytical solution is:
+
+$P = 10000 y$
+
 The results for both test configurations are identical and they are also identical to the results of the pressure line element.
 
 The picture below illustrates the pressure profile resulting from the simulation (as an example the 2D3N test is shown below).

diff --git a/.../tests/test_pressure_line_element/test_oblique_filter_element2D3N/MaterialParameters.json b/.../tests/test_pressure_line_element/test_oblique_filter_element2D3N/MaterialParameters.json
@@ -8,23 +8,16 @@
       },
       "Variables" : {
         "IGNORE_UNDRAINED"                 : false,
-        "YOUNG_MODULUS"                    : 1.000000e+07,
-        "POISSON_RATIO"                    : 0.000000e+00,
         "DENSITY_SOLID"                    : 2.650000e+03,
         "DENSITY_WATER"                    : 1.000000e+03,
         "POROSITY"                         : 1.000000e-01,
         "BULK_MODULUS_SOLID"               : 9.000000e+19,
         "BULK_MODULUS_FLUID"               : 1.000000e+20,
         "PERMEABILITY_XX"                  : 9.084000e-06,
         "DYNAMIC_VISCOSITY"                : 1.000000e-03,
-        "BIOT_COEFFICIENT"                 : 1.000000e+00,
         "RETENTION_LAW"                    : "PressureFilterLaw",
-        "SATURATED_SATURATION"             : 1.000000e+00,
-        "RESIDUAL_SATURATION"              : 0.000000e+00,
         "CROSS_AREA"                       : 1.0,
         "FILTER_LENGTH"                    : 3.0
-      },
-      "Tables": { 
       }
     }
   }]

diff --git a/...n/tests/test_pressure_line_element/test_oblique_filter_element2D3N/ProjectParameters.json b/...n/tests/test_pressure_line_element/test_oblique_filter_element2D3N/ProjectParameters.json
@@ -39,10 +39,6 @@
     "rayleigh_k"                         : 0.0,
     "strategy_type"                      : "newton_raphson",
     "convergence_criterion"              : "water_pressure_criterion",
-    "displacement_relative_tolerance"    : 1.0E-4,
-    "displacement_absolute_tolerance"    : 1.0E-9,
-    "residual_relative_tolerance"        : 1.0E-4,
-    "residual_absolute_tolerance"        : 1.0E-9,
     "water_pressure_relative_tolerance"  : 1.0E-4,
     "water_pressure_absolute_tolerance"  : 1.0E-9,
     "min_iterations"                     : 2,

diff --git a/.../tests/test_pressure_line_element/test_oblique_filter_element3D3N/MaterialParameters.json b/.../tests/test_pressure_line_element/test_oblique_filter_element3D3N/MaterialParameters.json
@@ -8,22 +8,16 @@
       },
       "Variables" : {
         "IGNORE_UNDRAINED"                 : false,
-        "YOUNG_MODULUS"                    : 1.000000e+07,
-        "POISSON_RATIO"                    : 0.000000e+00,
         "DENSITY_SOLID"                    : 2.650000e+03,
         "DENSITY_WATER"                    : 1.000000e+03,
         "POROSITY"                         : 1.000000e-01,
         "BULK_MODULUS_SOLID"               : 9.000000e+19,
         "BULK_MODULUS_FLUID"               : 1.000000e+20,
         "PERMEABILITY_XX"                  : 9.084000e-06,
         "DYNAMIC_VISCOSITY"                : 1.000000e-03,
-        "BIOT_COEFFICIENT"                 : 1.000000e+00,
         "RETENTION_LAW"                    : "PressureFilterLaw",
-        "SATURATED_SATURATION"             : 1.000000e+00,
         "CROSS_AREA"                       : 1.0,
         "FILTER_LENGTH"              : 3.0
-      },
-      "Tables": { 
       }
     }
   }]

diff --git a/...n/tests/test_pressure_line_element/test_oblique_filter_element3D3N/ProjectParameters.json b/...n/tests/test_pressure_line_element/test_oblique_filter_element3D3N/ProjectParameters.json
@@ -39,10 +39,6 @@
     "rayleigh_k"                         : 0.0,
     "strategy_type"                      : "newton_raphson",
     "convergence_criterion"              : "water_pressure_criterion",
-    "displacement_relative_tolerance"    : 1.0E-4,
-    "displacement_absolute_tolerance"    : 1.0E-9,
-    "residual_relative_tolerance"        : 1.0E-4,
-    "residual_absolute_tolerance"        : 1.0E-9,
     "water_pressure_relative_tolerance"  : 1.0E-4,
     "water_pressure_absolute_tolerance"  : 1.0E-9,
     "min_iterations"                     : 2,