Addressed review comments

KratosMultiphysics · May 14, 2024 · 6be0896 · 6be0896
1 parent d09c3ba
commit 6be0896
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/applications/GeoMechanicsApplication/geo_mechanics_application.h b/applications/GeoMechanicsApplication/geo_mechanics_application.h
@@ -602,8 +602,8 @@ class KRATOS_API(GEO_MECHANICS_APPLICATION) KratosGeoMechanicsApplication : publ
     const GeoThermalDispersionLaw mGeoThermalDispersion2DLaw{ConstitutiveLaw::SizeType(2)};
     const GeoThermalDispersionLaw mGeoThermalDispersion3DLaw{ConstitutiveLaw::SizeType(3)};
 
-    const GeoThermalFilterLaw mGeoThermalFilter2DLaw{std::size_t(1)};
-    const GeoThermalFilterLaw mGeoThermalFilter3DLaw{std::size_t(1)};
+    const GeoThermalFilterLaw mGeoThermalFilter2DLaw{ConstitutiveLaw::SizeType(1)};
+    const GeoThermalFilterLaw mGeoThermalFilter3DLaw{ConstitutiveLaw::SizeType(1)};
 
     ///@}
 

diff --git a/applications/GeoMechanicsApplication/tests/cpp_tests/test_thermal_filter_law.cpp b/applications/GeoMechanicsApplication/tests/cpp_tests/test_thermal_filter_law.cpp
@@ -31,8 +31,7 @@ KRATOS_TEST_CASE_IN_SUITE(CalculateThermalFilterLawMatrix, KratosGeoMechanicsFas
 
     const Matrix thermal_filter_matrix = geo_thermal_filter_law.CalculateThermalFilterMatrix(*cond_prop, info);
 
-    Matrix expected_solution = ZeroMatrix(1, 1);
-    expected_solution(0, 0)  = 1000.0;
+    Matrix expected_solution = ScalarMatrix(1, 1, 1000.0);
 
     constexpr double tolerance{1.0e-6};
 
@@ -43,9 +42,15 @@ KRATOS_TEST_CASE_IN_SUITE(CalculateThermalFilterLawMatrix, KratosGeoMechanicsFas
 KRATOS_TEST_CASE_IN_SUITE(GetWorkingSpaceDimension_ReturnsFilterDimensionValue, KratosGeoMechanicsFastSuite)
 {
     constexpr SizeType dimension = 1;
-    GeoThermalDispersionLaw geo_thermal_filter_law(dimension);
+    GeoThermalFilterLaw geo_thermal_filter_law(dimension);
 
     KRATOS_EXPECT_EQ(geo_thermal_filter_law.WorkingSpaceDimension(), dimension);
 }
 
+KRATOS_TEST_CASE_IN_SUITE(TestFilterThrowsWhenDimensionInvalid, KratosGeoMechanicsFastSuite)
+{
+    KRATOS_EXPECT_EXCEPTION_IS_THROWN(GeoThermalFilterLaw law{2},
+        "Got invalid number of dimensions. The dimension has to be 1, but got: 2")
+}
+
 } // namespace Kratos::Testing