Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install instructions for alpine #2299

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Update install instructions for alpine #2299

merged 2 commits into from
Nov 12, 2024

Conversation

jo-bitsch
Copy link
Contributor

As per the discussion in #699, document an easier way to install WeasyPrint from PyPI when using prebuilt wheels.

To keep the document consistent, I copied the context descriptions over from the other Linux flavors.

As per the discussion in Kozea#699, document an easier way to install WeasyPrint from PyPI when using prebuilt wheels.
@liZe
Copy link
Member

liZe commented Nov 11, 2024

Thanks a lot for this pull request!

Could you please use the same so:* notation for the list of packages without wheels? It will be more consistant and help spot the differences between the two lists.

Updated to match the format of the dependencies with wheels.

Also added `libwebp-dev` to the build dependencies. Otherwise building would work but running

```
weasyprint https://weasyprint.org/ /tmp/test.pdf
```

would fail to include the webp images with error code
```
/usr/lib/python3.10/site-packages/PIL/Image.py:3496: UserWarning: image file could not be identified because WEBP support not installed
```

The prebuilt `Pillow` binary in the wheel includes `webp` support already.
```
@jo-bitsch
Copy link
Contributor Author

I updated the install instructions for packages without wheels and also added libwebp-dev, so that the default sample command

weasyprint https://weasyprint.org/ /tmp/test.pdf

also works for the non-wheel build.

(The prebuilt wheels already include support for webp.)

Thanks for being so responsive about this PR!

@liZe liZe merged commit 94c23b3 into Kozea:main Nov 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants