Don’t cache Pango fonts #2149
Merged
Don’t cache Pango fonts #2149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calculating the description hash is cheap, but we really should cache this in the FontConfiguration object where the Pango map is stored. Fix #2144.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
pango_fontis a pointer, equality is done with the address of the pointer, not the actual font. Pango fonts don’t change for a defined Pango map, but it’s possible with two different Pango maps to get different fonts stored at the same address.Calculating the description hash is cheap, so we can avoid the cache. But we really should cache this in the FontConfiguration object where the Pango map is stored.
Fix #2144.