Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix right-to-left tables with collapsed borders #2058

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Fix right-to-left tables with collapsed borders #2058

merged 3 commits into from
Jun 14, 2024

Conversation

liZe
Copy link
Member

@liZe liZe commented Feb 7, 2024

Fix #2055.

Related to #2056.

@liZe
Copy link
Member Author

liZe commented Feb 7, 2024

This PR is not ready yet. #2055 is "fixed", but that’s just a workaround: border colors are wrong.

Here’s another example showing what’s left to fix:

<style>
  table {
    border-collapse:collapse;
    margin-bottom: 1em;
  }
  tr {
    border-left: 5px solid fuchsia;
    border-right: 15px solid purple;
  }
  td.right {
    background-color: yellow;
    border-bottom: 5px solid orange;
  }
  td.left {
    background-color: aqua;
    border-bottom: 15px solid teal;
  }
</style>
<table style="direction: ltr;">
  <tr>
    <td class="left">XX</td>
    <td class="right">XX XX XX</td>
  </tr>
</table>


<table style="direction: rtl;">
  <tr>
    <td class="right">XX XX XX</td>
    <td class="left">XX</td>
  </tr>
</table>

kygoh added a commit to kygoh/WeasyPrint that referenced this pull request Feb 13, 2024
@liZe liZe marked this pull request as ready for review June 14, 2024 09:19
@liZe liZe merged commit 64b3568 into main Jun 14, 2024
13 checks passed
@liZe liZe deleted the rtl-table branch June 14, 2024 09:29
@liZe liZe added this to the 63.0 milestone Jun 14, 2024
@liZe liZe added the bug Existing features not working as expected label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Existing features not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text in table with style="direction: rtl;" overlaps collapsed border
1 participant